Skip to content

chore!: remove direct imports & publish types #1485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 29, 2023

Conversation

joshuaellis
Copy link
Contributor

What does it do?

  • removes the ability to do import { x } from '@strapi/design-system'
  • publishes types with the design-system

Related issue(s)/PR(s)

  • resolves CONTENT-1682

@joshuaellis joshuaellis added pr: chore This PR contains chore tasks (cleanups, configs, tooling...) flag: 💥 Breaking change This PR contains breaking changes and should not be merged source: design-system relates to design-system package labels Nov 28, 2023
@joshuaellis joshuaellis self-assigned this Nov 28, 2023
Copy link

changeset-bot bot commented Nov 28, 2023

🦋 Changeset detected

Latest commit: 3e6f28b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@strapi/design-system Major
@strapi/ui-primitives Major
@strapi/icons Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Nov 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
design-system ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 29, 2023 11:04am
design-system-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 29, 2023 11:04am

This comment was marked as spam.

@joshuaellis joshuaellis merged commit ebdf75c into release/v2 Nov 29, 2023
@joshuaellis joshuaellis deleted the v2/remove-direct-imports branch November 29, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flag: 💥 Breaking change This PR contains breaking changes and should not be merged pr: chore This PR contains chore tasks (cleanups, configs, tooling...) source: design-system relates to design-system package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants