Skip to content

chore(design-system)!: set base font-size to 62.5% to be 10px #1486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 29, 2023

Conversation

joshuaellis
Copy link
Contributor

What does it do?

  • set font-size in GlobalStyles to 62.5% this makes 1rem === 10px which is a million times easier to work with.
  • refactor styles to reflect this

Related issue(s)/PR(s)

  • resolves CONTENT-1683

@joshuaellis joshuaellis added pr: chore This PR contains chore tasks (cleanups, configs, tooling...) flag: 💥 Breaking change This PR contains breaking changes and should not be merged source: design-system relates to design-system package labels Nov 28, 2023
@joshuaellis joshuaellis self-assigned this Nov 28, 2023
Copy link

changeset-bot bot commented Nov 28, 2023

🦋 Changeset detected

Latest commit: 109d8bf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@strapi/design-system Major
@strapi/ui-primitives Major
@strapi/icons Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Nov 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
design-system ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 29, 2023 1:11pm
design-system-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 29, 2023 1:11pm

Copy link
Contributor

github-actions bot commented Nov 28, 2023

Size Change: -297 B (0%)

Total Size: 499 kB

Filename Size Change
packages/strapi-design-system/dist/index.js 191 kB -151 B (0%)
packages/strapi-design-system/dist/index.mjs 189 kB -146 B (0%)
ℹ️ View Unchanged
Filename Size
packages/primitives/dist/index.js 16.5 kB
packages/primitives/dist/index.mjs 16 kB
packages/strapi-icons/dist/index.js 43.3 kB
packages/strapi-icons/dist/index.mjs 43 kB

compressed-size-action

@joshuaellis joshuaellis force-pushed the v2/change-base-font-to-10 branch from 307bdca to 109d8bf Compare November 29, 2023 13:08
@joshuaellis joshuaellis merged commit ccc14d2 into release/v2 Nov 29, 2023
@joshuaellis joshuaellis deleted the v2/change-base-font-to-10 branch November 29, 2023 13:45
joshuaellis added a commit that referenced this pull request Dec 5, 2023
* chore(design-system)!: set base font-size to 62.5% to be 10px

* chore: add breaking changes doc

* chore: fix snapshots
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flag: 💥 Breaking change This PR contains breaking changes and should not be merged pr: chore This PR contains chore tasks (cleanups, configs, tooling...) source: design-system relates to design-system package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants