-
Notifications
You must be signed in to change notification settings - Fork 188
enhancement! : remove all field label, field hint, field errors from all possible inputs #1693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhancement! : remove all field label, field hint, field errors from all possible inputs #1693
Conversation
🦋 Changeset detectedLatest commit: 9351af9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
These are all breaking changes, lets not forget to update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You've deleted a lot of the stories, but why not create a formula for how to document Inputs in storybook? We should be showing how to use them as a field too.
We're also inconsistent on the naming of components sometimes its XInput sometimes its just X, what do other design-systems do in these circumstances?
Size Change: -3.39 kB (-1%) Total Size: 487 kB
ℹ️ View Unchanged
|
e276978
to
47a038e
Compare
2177b71
to
6511c08
Compare
c3f8686
to
8887e02
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nearly there 💪🏼
i've done some polishing on 8887e02
However, we've missed the DatePicker
and DateTimePicker
components, they also need to have their "field" stuff removed, i'm gonna make a follow-up ticket to review the Field
API, I think this can be improved before the next beta.
Thank you for changes, and about datepicker I dont know my search didn't find it because I had a space added, but I will make those changes quickly 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also, dont forget to |
What does it do?
Why is it needed?
As a developer I don’t want complete inputs e.g. that contain a FieldHint / Label etc. I just want “inputs”
How to test it?
Please check stories for updated inputs.
Related Issues