chore: remove & rename icons #1696
Conversation
joshuaellis
added
pr: chore
joshuaellis
requested review from
madhurisandbhor,
christiancp100 and
jhoward1994
🦋 Changeset detectedLatest commit: 2615b1c The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
joshuaellis
force-pushed
the
chore/update-icons
branch
from
d4b584d to
94037d9
Compare
| import { Title, Meta } from '@storybook/blocks'; | ||
|
|
||
| <Meta title="Primitives/Overview" parameters={{ viewMode: 'docs' }} /> | ||
|
|
||
| <Title>Overview</Title> |
There was a problem hiding this comment.
Do we need these files?
docs/stories/primitives/overview.mdx
docs/stories/foundations/overview.mdx
We end up with empty overview pages in storybook which looks a bit strange
There was a problem hiding this comment.
I'm gonna keep them for now, the storybook in v2 is very much a WIP, we have tickets to amend this sort of stuff, but it's there to start building the shape we want 💪🏼
| @@ -0,0 +1,95 @@ | |||
| import { Typography, lightTheme } from '@strapi/design-system'; | |||
There was a problem hiding this comment.
Thank you! these new pages will be so useful
this looks incorrect with new changes, needs width, height mentioned?
|
let's write a bug in JIRA! :) |
What does it do?
icon's a better template so we can apply fill & stroke with theme colors directly on themcurrentColorIconcomponentAccessibleIconutility componentHow to test it?
Related issue(s)/PR(s)