Skip to content

fix(design-system): codemirror packages that aren't in package.json are declared as external #1709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 30, 2024

Conversation

joshuaellis
Copy link
Contributor

@joshuaellis joshuaellis commented Apr 29, 2024

What does it do?

  • finds the codemirror deps we access but aren't declared in the package.json and make them external to avoid being bundled

Why is it needed?

  • JSON fields crash the strapi app because we load more than one version of codemirror state

Related issue(s)/PR(s)

@joshuaellis joshuaellis added pr: fix This PR is fixing a bug source: design-system relates to design-system package labels Apr 29, 2024
@joshuaellis joshuaellis self-assigned this Apr 29, 2024
Copy link

changeset-bot bot commented Apr 29, 2024

🦋 Changeset detected

Latest commit: 6d977e6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@strapi/design-system Patch
@strapi/ui-primitives Patch
@strapi/icons Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Apr 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
design_system_v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 29, 2024 3:47pm
design-system ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 29, 2024 3:47pm
design-system-website ❌ Failed (Inspect) Apr 29, 2024 3:47pm

Copy link
Contributor

github-actions bot commented Apr 29, 2024

Size Change: -191 kB (-39%) 🎉

Total Size: 295 kB

Filename Size Change
packages/strapi-design-system/dist/index.js 98.1 kB -95.6 kB (-49%) 🎉
packages/strapi-design-system/dist/index.mjs 96.7 kB -95.7 kB (-50%) 🏆
ℹ️ View Unchanged
Filename Size
packages/primitives/dist/index.js 16.6 kB
packages/primitives/dist/index.mjs 16.1 kB
packages/strapi-icons/dist/index.js 22.1 kB
packages/strapi-icons/dist/index.mjs 21.7 kB
packages/strapi-icons/dist/symbols-index.js 11.9 kB
packages/strapi-icons/dist/symbols-index.mjs 11.8 kB

compressed-size-action

Copy link
Contributor

@innerdvations innerdvations left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I didn't test it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: fix This PR is fixing a bug source: design-system relates to design-system package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: 2.0.0-beta.2 codemirror error Unrecognized extension value in extension set
2 participants