fix: menu item disabled style wrongly applied #1760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simotae14
added
pr: fix
🦋 Changeset detectedLatest commit: 46ad573 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
remidej
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Extends the CSS rule in the Menu.Item in case the aria-disabled attribute has just a true value, otherwise the disabled state is applied even if the menu item is not disabled
Why is it needed?
Otherwise for example when we use a NavLink in the Menu.Item the aria-disabled attribute is present even if it is false and with the old css rule the style is applied in both cases, true or false
An example in the CMS is this one
How to test it?
link this branch to your version of the CMS by following these instructions https://github.com/strapi/design-system/blob/main/CONTRIBUTING.md#example-steps
Related issue(s)/PR(s)
fixes strapi/strapi#20774