Skip to content

fix: remove static placeholder from SubNavHeader #1766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

madhurisandbhor
Copy link
Contributor

What does it do?

User can pass a placeholder prop to SubNavHeader now.

Related issue(s)/PR(s)

Fixes #1201

@madhurisandbhor madhurisandbhor added pr: fix This PR is fixing a bug source: design-system relates to design-system package labels Jul 29, 2024
@madhurisandbhor madhurisandbhor self-assigned this Jul 29, 2024
Copy link

vercel bot commented Jul 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
design-system ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 29, 2024 0:30am

Copy link

changeset-bot bot commented Jul 29, 2024

🦋 Changeset detected

Latest commit: 70207b0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@strapi/design-system Patch
@strapi/icons Patch
@strapi/ui-primitives Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@madhurisandbhor madhurisandbhor merged commit d62d58b into main Jul 29, 2024
12 checks passed
@madhurisandbhor madhurisandbhor deleted the fix/subNavHeader-placeholder branch July 29, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: fix This PR is fixing a bug source: design-system relates to design-system package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat]: SubNavHeader search's placeholder can't be customized
2 participants