Skip to content

fix: datetime fields responsive #1920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 5, 2025
Merged

fix: datetime fields responsive #1920

merged 4 commits into from
Jun 5, 2025

Conversation

Adzouz
Copy link
Contributor

@Adzouz Adzouz commented Jun 3, 2025

What does it do?

Improve the responsive of the datetime picker fields on small containers.

1853.bug._.No.property.available.to.stack.date.and.time.picker.fields.vertically.column.instead.of.row.mp4

I also took the liberty to unify the size between the two elements (most of the time it's 50/50 in the admin interface)

Why is it needed?

Improve the experience on smaller screens or when including a datetime field inside a modal / small container.

How to test it?

  • Go to storybook > Inputs > DateTimePicker
  • Try to resize the window

Related issue(s)/PR(s)

Resolves #1853

🚀

@Adzouz Adzouz self-assigned this Jun 3, 2025
@Adzouz Adzouz added pr: fix This PR is fixing a bug severity: low If the issue only affects a very niche base of users and an easily implemented workaround can solve source: design-system relates to design-system package labels Jun 3, 2025
Copy link

changeset-bot bot commented Jun 3, 2025

🦋 Changeset detected

Latest commit: ff3ad4a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@strapi/design-system Patch
@strapi/icons Patch
@strapi/ui-primitives Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jun 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
design-system ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 5, 2025 9:12am

@simotae14
Copy link
Contributor

Hello @Adzouz , thanks a lot for this precious fix.
Now the Date time picker is responsive 🌟
I am not sure, btw, it is the request made in the github issue, I mean, I am not sure if they want us to expose a property to let them align vertically or horizontally the DateTimePicker.
Can you please check with https://github.com/TMSchipper if yours it is the desired behaviour?

Copy link
Contributor

@remidej remidej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice improvement 👍

just check with Louis about that tiny design change

@Adzouz
Copy link
Contributor Author

Adzouz commented Jun 5, 2025

I checked with both of them and we have a green light. Merging it, thanks a lot guys 🚀

@Adzouz Adzouz merged commit 7c70603 into main Jun 5, 2025
11 checks passed
@Adzouz Adzouz deleted the fix/datetime-responsive branch June 5, 2025 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: fix This PR is fixing a bug severity: low If the issue only affects a very niche base of users and an easily implemented workaround can solve source: design-system relates to design-system package
Projects
Status: To triage
Development

Successfully merging this pull request may close these issues.

[bug]: No property available to stack date and time picker fields vertically [column instead of row]
3 participants