Skip to content

fix: wrong color placeholder #1921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 4, 2025
Merged

fix: wrong color placeholder #1921

merged 2 commits into from
Jun 4, 2025

Conversation

Adzouz
Copy link
Contributor

@Adzouz Adzouz commented Jun 4, 2025

What does it do?

Fixes the color of the placeholders in input elements in the design system.

Why is it needed?

Placeholder were using the default browser color and it's not part of the color palette defined by Strapi design system.

How to test it?

  • Go to Storybook
  • Go to the following components and be sure all value is cleared from them
    • Field
    • Combobox
    • Searchbar
    • DatePicker
    • NumberInput
    • TextInput
    • Textarea

Related issue(s)/PR(s)

Resolves #1842

🚀

@Adzouz Adzouz self-assigned this Jun 4, 2025
@Adzouz Adzouz added pr: fix This PR is fixing a bug severity: low If the issue only affects a very niche base of users and an easily implemented workaround can solve source: design-system relates to design-system package labels Jun 4, 2025
Copy link

changeset-bot bot commented Jun 4, 2025

🦋 Changeset detected

Latest commit: 53ea241

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@strapi/design-system Patch
@strapi/icons Patch
@strapi/ui-primitives Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jun 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
design-system ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 4, 2025 8:58am

Copy link
Contributor

@simotae14 simotae14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @Adzouz for your contribution,
I checked your solution with the Dark theme (where the difference is more visible) and it looks great.
I am gonna approve it, 🚀

@Adzouz Adzouz merged commit d7c9c41 into main Jun 4, 2025
11 checks passed
@Adzouz Adzouz deleted the fix/color-placeholder branch June 4, 2025 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: fix This PR is fixing a bug severity: low If the issue only affects a very niche base of users and an easily implemented workaround can solve source: design-system relates to design-system package
Projects
Status: To triage
Development

Successfully merging this pull request may close these issues.

[bug]: The placeholder doesn't have the right color in some inputs
2 participants