Skip to content

fix: disabled checked checkboxes border #1928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2025
Merged

Conversation

Adzouz
Copy link
Contributor

@Adzouz Adzouz commented Jun 12, 2025

What does it do?

Fix the border color of checked disabled checboxes. They are supposed to be grey but currently they are blue due to a little CSS condition missing in the target rule.

Screenshot of the issue:
image

Why is it needed?

It's not very intuitive for the user and he couldn't understand if the checkbox is focused, active or not.

How to test it?

  • Go to the admin interface > Settings > Roles
  • Click on Super Admin role to display the disabled checboxes

Related issue(s)/PR(s)

Resolves strapi/strapi#22032

🚀

@Adzouz Adzouz self-assigned this Jun 12, 2025
@Adzouz Adzouz added pr: fix This PR is fixing a bug source: design-system relates to design-system package labels Jun 12, 2025
Copy link

changeset-bot bot commented Jun 12, 2025

🦋 Changeset detected

Latest commit: ccc9b20

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@strapi/design-system Patch
@strapi/icons Patch
@strapi/ui-primitives Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jun 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
design-system ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 13, 2025 1:40pm

Copy link
Contributor

@markkaylor markkaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Adzouz Adzouz force-pushed the fix/checkboxes-disabled-checked branch from 0a186f2 to ccc9b20 Compare June 13, 2025 13:30
@Adzouz Adzouz merged commit a3535e7 into main Jun 13, 2025
9 of 11 checks passed
@Adzouz Adzouz deleted the fix/checkboxes-disabled-checked branch June 13, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: fix This PR is fixing a bug source: design-system relates to design-system package
Projects
Status: To triage
Development

Successfully merging this pull request may close these issues.

[Design] Disabled checkboxes in Super Admin settings have a blue border and the check hasn’t the right color
2 participants