Skip to content

fix: wrapping content of dialog in overlay to restore pointer-events #1930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2025

Conversation

Adzouz
Copy link
Contributor

@Adzouz Adzouz commented Jun 13, 2025

What does it do?

Wraps the content of a dialog inside the overlay to restore the pointer-events and allow user to scroll in select that would be included in a dialog.

Why is it needed?

The user can't scroll in a select inside a dialog.

How to test it?

  • Go to the admin interface > Content manager
  • Pick a localized collection
  • Create or edit an item
  • Create multiple languages variations of the item (at least 5)
  • Create again a new language variation
  • Click on the globe icon on top right (Fill in from another locale)

Related issue(s)/PR(s)

Resolves strapi/strapi#23205

🚀

@Adzouz Adzouz requested a review from markkaylor June 13, 2025 08:47
@Adzouz Adzouz self-assigned this Jun 13, 2025
@Adzouz Adzouz added pr: fix This PR is fixing a bug source: design-system relates to design-system package labels Jun 13, 2025
Copy link

changeset-bot bot commented Jun 13, 2025

🦋 Changeset detected

Latest commit: 12585dc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@strapi/design-system Patch
@strapi/icons Patch
@strapi/ui-primitives Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jun 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
design-system ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 13, 2025 8:47am

Copy link
Contributor

@markkaylor markkaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Adzouz Adzouz merged commit 21676c1 into main Jun 13, 2025
10 of 12 checks passed
@Adzouz Adzouz deleted the fix/dialog-overlay branch June 13, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: fix This PR is fixing a bug source: design-system relates to design-system package
Projects
Status: To triage
Development

Successfully merging this pull request may close these issues.

Select is missing a scrollbar inside modal
2 participants