Pass the required prop to the combobox FieldLabel #690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
HichamELBSI
requested review from
gu-stav,
ronronscelestes,
simotae14 and
udimberto
gu-stav
reviewed
Aug 30, 2022
| @@ -250,7 +251,11 @@ export const Combobox = ({ | |||
| {value} | |||
| </VisuallyHidden> | |||
| <Stack spacing={label || hint || error ? 1 : 0}> | |||
| {label && <FieldLabel id={labelId}>{label}</FieldLabel>} | |||
| {label && ( | |||
| <FieldLabel required={required} id={labelId}> | |||
There was a problem hiding this comment.
Good catch! Could you also check if the labelAction is passed through as action={labelAction}? It seems to be missing too.
There was a problem hiding this comment.
Nice catch! Pushed 👍🏽
udimberto
approved these changes
Aug 30, 2022
Signed-off-by: HichamELBSI <[email protected]>
HichamELBSI
force-pushed
the
enh/required-combobox
branch
from
a75be4d to
42add10
Compare
HichamELBSI
commented
Aug 30, 2022
| onClear, | ||
| placeholder, | ||
| required, | ||
| value, |
There was a problem hiding this comment.
ℹ️ Just sorting the props list 😅
There was a problem hiding this comment.
💡 We need an eslint rule for that.
gu-stav
approved these changes
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: HichamELBSI [email protected]
What does it do?
Allow the combobox to display the required state.