Add placement props to Popover component #709
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HichamELBSI
added
the
pr: enhancement
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
joshuaellis
suggested changes
Sep 30, 2022
| /** | ||
| * The popover position | ||
| */ | ||
| placement: PropTypes.string, |
There was a problem hiding this comment.
I think this prop can be better defined, there are specific options available:
type Placement =
| 'top'
| 'top-start'
| 'top-end'
| 'right'
| 'right-start'
| 'right-end'
| 'bottom'
| 'bottom-start'
| 'bottom-end'
| 'left'
| 'left-start'
| 'left-end';There was a problem hiding this comment.
Awesome thank you, I was looking for this 😄
Signed-off-by: HichamELBSI <[email protected]>
HichamELBSI
force-pushed
the
enh/add-popover-placement
branch
from
ab940a0 to
04a3f73
Compare
joshuaellis
approved these changes
Sep 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: HichamELBSI [email protected]
What does it do?
Since the Popover is handled by
floating-ui, we are now able to choose where the popover will be handled. This update will be helpful for the Strapi Cloud app