-
Notifications
You must be signed in to change notification settings - Fork 187
[enhancement]: IconButton #746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
joshuaellis
merged 8 commits into
main
from
enhancement/make-icon-buttons-more-accessible
Nov 8, 2022
Merged
[enhancement]: IconButton #746
joshuaellis
merged 8 commits into
main
from
enhancement/make-icon-buttons-more-accessible
Nov 8, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…children also adds accessible properties to `icon` or `children`
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Size Change: +15.5 kB (0%) Total Size: 6.37 MB
ℹ️ View Unchanged
|
gu-stav
reviewed
Nov 2, 2022
packages/strapi-design-system/src/IconButton/IconButton.stories.mdx
Outdated
Show resolved
Hide resolved
gu-stav
approved these changes
Nov 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm good with that. Very good idea!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
aria-label
cause there's no excuse for no accessibilityeslint
toerror
cause it's a better DX imoicon
/children
viacloneElement
VisuallyHidden
spans because iirc translators are more likely to translate those than aria-labels and it's clearer from a code POVWhy is it needed?