-
Notifications
You must be signed in to change notification settings - Fork 187
[Fix] Remove alt as required in Avatar #771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Size Change: +136 B (0%) Total Size: 6.41 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a better default would be ""
because iirc that informs screenreaders to ignore the image. wdyt?
@joshuaellis I can't entirely agree :) To make it an empty string by default means that we assume every image rendered with |
I agree - tested myself and I don't think having blank instead of filename by default would be great, user can still add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure 👍🏼
What
Removing
required
foralt
prop in Avatar component - decided after an alt fallback discussion