Skip to content

Require Go 1.18 #1956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 8, 2022
Merged

Require Go 1.18 #1956

merged 1 commit into from
Aug 8, 2022

Conversation

skitt
Copy link
Member

@skitt skitt commented Aug 8, 2022 •
edited
Loading

Now that Go 1.19 is released, require 1.18.

Depends on submariner-io/shipyard#899
Signed-off-by: Stephen Kitt [email protected]

@skitt
Require Go 1.18
581769a 
Now that Go 1.19 is released, require 1.18.

Signed-off-by: Stephen Kitt <[email protected]>
@submariner-bot
Copy link
Contributor

🤖 Created branch: z_pr1956/skitt/go-1.18
🚀 Full E2E won't run until the "ready-to-test" label is applied. I will add it automatically once the PR has 2 approvals, or you can add it manually.

@skitt skitt mentioned this pull request Aug 8, 2022
Merged
@skitt skitt added dependencies Pull requests that update a dependency file maintenance Small, unplanned tasks related to ongoing maintenance and removed dependent labels Aug 8, 2022
@submariner-bot submariner-bot added the ready-to-test When a PR is ready for full E2E testing label Aug 8, 2022
@tpantelis tpantelis enabled auto-merge (rebase) August 8, 2022 17:45
@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2022

This PR/issue depends on:

@tpantelis tpantelis merged commit 71a9b2d into submariner-io:devel Aug 8, 2022
@submariner-bot
Copy link
Contributor

🤖 Closed branches: [z_pr1956/skitt/go-1.18]

@skitt skitt deleted the go-1.18 branch August 9, 2022 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nyechiel nyechiel nyechiel approved these changes

@tpantelis tpantelis tpantelis approved these changes

@Oats87 Oats87 Awaiting requested review from Oats87 Oats87 is a code owner

@sridhargaddam sridhargaddam Awaiting requested review from sridhargaddam sridhargaddam is a code owner

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file maintenance Small, unplanned tasks related to ongoing maintenance ready-to-test When a PR is ready for full E2E testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@skitt @submariner-bot @nyechiel @tpantelis