✨Custom block quote #646
Merged
✨Custom block quote #646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoLC
force-pushed
the
feature/custom-block-quote
branch
from
fb51e86 to
8b89302
Compare
3 tasks
AntoLC
force-pushed
the
feature/custom-block-quote
branch
6 times, most recently
from
7a56e89 to
14cf008
Compare
Closed
Add a custom block to quote in the editor.
We recently changed the default title behavior. It can now be undefined, we have to change the types accordingly.
Create the feature doc-export, it will be responsible for exporting the document.
As made for TablePDF, we separate the block mapping in separate files. This will allow us to have a better separation of concerns and to have a more maintainable codebase. We improve as well the typing. It will be easier to add new blocks in the future.
We have a new block type, the quote block. We have to adapt the export to handle this new block type.
AntoLC
force-pushed
the
feature/custom-block-quote
branch
from
14cf008 to
c6208a0
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
We decided to split the pull request #566 to still improve the
Alertcustom block.This PR will add the custom block
Quoteto the editor.Proposal
Demo
scrnli_RElTB09jk3R4lf.webm
PDF:
Docx: