Skip to content

🔒️(back) restrict access to favorite_list endpoint #690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 7, 2025

Conversation

lunika
Copy link
Member

@lunika lunika commented Mar 6, 2025

Purpose

favorite_list endpoint is accessible to anonymous user. This lead to an
error 500. This endpoint should be accessible only to authenticated
users.

Proposal

  • 🔒️(back) restrict access to favorite_list endpoint
  • 🐛(back) fix ValidationError exception handler

@lunika lunika added the bug Something isn't working label Mar 6, 2025
@lunika lunika requested a review from sampaccoud March 6, 2025 14:26
@lunika lunika self-assigned this Mar 6, 2025
@lunika lunika force-pushed the fix/favorite_list branch 2 times, most recently from d73a69b to 8baae53 Compare March 6, 2025 14:31
Copy link
Member

@sampaccoud sampaccoud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Clean fix 🙏🙏🙏

lunika added 2 commits March 7, 2025 08:53

Verified

This commit was signed with the committer’s verified signature.
samueltardieu Samuel Tardieu
The exception handler for the ValidationError was not testing correctly
the existence of some attributes like `message_dict`.

Verified

This commit was signed with the committer’s verified signature.
samueltardieu Samuel Tardieu
favorite_list endpoint is accessible to anonymous user. This lead to an
error 500. This endpoint should be accessible only to authenticated
users.
@lunika lunika force-pushed the fix/favorite_list branch from 8baae53 to 59e2fda Compare March 7, 2025 07:53
@lunika lunika enabled auto-merge (rebase) March 7, 2025 07:53
@lunika lunika merged commit 0cabb65 into main Mar 7, 2025
19 of 20 checks passed
@lunika lunika deleted the fix/favorite_list branch March 7, 2025 08:04
@AntoLC AntoLC mentioned this pull request Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants