Skip to content

✨(settings) Allow configuring PKCE for the SSO #886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2025
Merged

✨(settings) Allow configuring PKCE for the SSO #886

merged 1 commit into from
Apr 28, 2025
+12 −0

Conversation

Tom-Hubrecht
Copy link
Contributor

C.f. https://mozilla-django-oidc.readthedocs.io/en/latest/settings.html#OIDC_USE_PKCE

Purpose

Add pkce settings

Proposal

Get the settings from the environment

@AntoLC AntoLC requested review from sampaccoud and lunika April 22, 2025 07:51
@AntoLC AntoLC added the backend label Apr 22, 2025
lunika
lunika reviewed Apr 28, 2025
View reviewed changes
Copy link
Member

@lunika lunika left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

Can you update the CHANGELOG with your modification and also sign off your commit (see the contributing file).

Thank you

@Tom-Hubrecht
✨(settings) Allow configuring PKCE for the SSO

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
Loading
Loading status checks…
d797cfe 
C.f.
https://mozilla-django-oidc.readthedocs.io/en/latest/settings.html#OIDC_USE_PKCE

Signed-off-by: Tom Hubrecht <[email protected]>
@lunika lunika enabled auto-merge (rebase) April 28, 2025 10:45
auto-merge was automatically disabled April 28, 2025 10:53

Base branch requires signed commits

@lunika lunika merged commit 5cdbdbf into suitenumerique:main Apr 28, 2025
17 of 18 checks passed
@lunika
Copy link
Member

lunika commented Apr 28, 2025

Thanks !

This was referenced May 2, 2025
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunika lunika

@sampaccoud sampaccoud

Assignees
No one assigned
Labels
backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Tom-Hubrecht @lunika @AntoLC