✨(back) allow theme customnization using a configuration file #948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunika
force-pushed
the
feat/customization-file
branch
from
a30af40 to
f7eeef2
Compare
AntoLC
reviewed
May 9, 2025
lunika
force-pushed
the
feat/customization-file
branch
2 times, most recently
from
b334c7c to
0a4ec40
Compare
AntoLC
approved these changes
May 12, 2025
lunika
force-pushed
the
feat/customization-file
branch
2 times, most recently
from
a6502b9 to
4cd469c
Compare
lunika
force-pushed
the
feat/customization-file
branch
2 times, most recently
from
8eb56a9 to
3eaecc3
Compare
We want to customize the theme by using a configuration file. This configuration file path can be defined using the settings THEME_CUSTOMIZATION_FILE_PATH. If this file does not exists or is an invalid json, an empty json object will be added in the config endpoint.
With the configuration file, the footer endpoint can be removed and will not be used anymore by the front application.
In order to load a custom theme file with our helm chart, we allow to load the content of a file into a config map and then use this configmap as a volume in the backend deployment
We want to change the cache key prefix using an environment variable. This settings can be changed at every deployment in order to reset to use a fresh new cache.
The env.d/development/common file sets AI_FEATURE_ENABLED=true. When pytest starts it imports these variables, so the /api/v1.0/config endpoint returns AI_FEATURE_ENABLED=True and the test_api_config assertion fails. Explicitly overriding AI_FEATURE_ENABLED=False in test_api_config restores the expected behaviour and makes the whole test-suite green. Signed-off-by: ReinforcedKnowledge <[email protected]>
lunika
force-pushed
the
feat/customization-file
branch
from
3eaecc3 to
4b0fd22
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
We want to customize the theme by using a configuration file. This configuration file path can be defined using the settings THEME_CUSTOMIZATION_FILE_PATH. If this file does not exists or is an invalid json, an empty json object will be added in the config endpoint.
Proposal