♻️ (frontend) do multiple refacto #949
Conversation
Zorin95670
force-pushed
the
improvement/code_warning
branch
from
d94672a to
571c240
Compare
| @@ -1,4 +1,4 @@ | |||
| var config = { | |||
| const config = { | |||
There was a problem hiding this comment.
This can be enforced by the use of this eslint rule BTW:
https://eslint.org/docs/latest/rules/no-var
There was a problem hiding this comment.
Add a commit that modify configuration to include root file.
Zorin95670
force-pushed
the
improvement/code_warning
branch
3 times, most recently
from
1670302 to
5a82713
Compare
There was a problem hiding this comment.
Hi, thank you for your contribution !
We try to keep meaningful commits in the history, could you squash them to have I think 3 commits ?
- one about minor refactoring (condition etc..)
- one about adding documentation
- one about adding tests
Same about the changelog, only meaningful entries, maybe 1 about documentation and 1 about coverage improvement should be enough, wdyt ?
Thank you.
| @@ -1,4 +1,4 @@ | |||
| import { forwardRef } from 'react'; | |||
| import React, { forwardRef } from 'react'; | |||
There was a problem hiding this comment.
We pin to "react19.1.0", so adding "React" is not necessary, same for the others.
docs/src/frontend/package.json
Line 38 in bd79f84
There was a problem hiding this comment.
Remove commit that make this change!
Zorin95670
force-pushed
the
improvement/code_warning
branch
from
5a82713 to
33a1578
Compare
- improve condition statements - add "no-var" rule in eslint - remove some unnecessary variables Signed-off-by: Zorin95670 <[email protected]>
Improve and add jsdoc. Signed-off-by: Zorin95670 <[email protected]>
Improve the test coverage of the "api" modules. Signed-off-by: Zorin95670 <[email protected]>
AntoLC
force-pushed
the
improvement/code_warning
branch
from
33a1578 to
29ea6b8
Compare
Purpose