Increase density of ActionMenu#3436
Merged
Merged
Conversation
Allow configuring size of ActionMenu. Supports `m` (current and default variant) and `s`.
🦋 Changeset detectedLatest commit: 84007c2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Size Change: +23 B (0%) Total Size: 753 kB
ℹ️ View Unchanged
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3436 +/- ##
=======================================
Coverage 93.74% 93.74%
=======================================
Files 196 196
Lines 4395 4395
Branches 1715 1710 -5
=======================================
Hits 4120 4120
Misses 248 248
Partials 27 27 🚀 New features to boost your workflow:
|
Member
|
What use case(s) do you have in mind for a smaller While I personally agree that the current size feels too large, I don't think that making the size configurable is the best approach. We'd need to come up with clear guidelines when to use which size to ensure consistency. A better alternative might be to decrease the default size of the |
Contributor
Author
|
@connor-baer specific use-case where the current size felt really huge was in a trailing component in a list item group using a icon button as the trigger. Agree, this is just a proposal, no strong feelings if we close this. |
Remove size options, instead adjust the sizing of the default variant.
matoous
force-pushed
the
md/ActionMenu-s-variant
branch
from
8a2fcdc to
51129b4
Compare
connor-baer
changed the title
connor-baer
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The
ActionMenulooks oversized, especially in combination with a small trigger button.Approach and changes
Definition of done