Tweak the component facelifts#3441
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: e70e50b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
connor-baer
commented
Jan 29, 2026
| @@ -1,5 +1,5 @@ | |||
| .label { | |||
| --checkbox-size: var(--cui-icon-sizes-mega); | |||
| --checkbox-size: 1.25rem; | |||
Member
Author
There was a problem hiding this comment.
Using rem here since the checkbox should scale with the font size.
Contributor
There was a problem hiding this comment.
Should we do this to icons too ? Icons are usually aligned with text and I think they should scale too.
Member
Author
There was a problem hiding this comment.
Good point! That would mean changing the --cui-icon-sizes-* tokens from px to rem. Do you think we should treat this as a breaking change?
Contributor
There was a problem hiding this comment.
If the tokens are used correctly, I don't think so 🤔
Contributor
|
Size Change: +58 B (+0.01%) Total Size: 759 kB
ℹ️ View Unchanged
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #3441 +/- ##
=======================================
Coverage 93.74% 93.74%
=======================================
Files 197 197
Lines 4394 4394
Branches 1713 1713
=======================================
Hits 4119 4119
Misses 248 248
Partials 27 27
🚀 New features to boost your workflow:
|
connor-baer
force-pushed
the
feat/brand-refresh-components
branch
from
9f829c9 to
14a5149
Compare
sirineJ
approved these changes
Mar 12, 2026
| @@ -1,5 +1,5 @@ | |||
| .label { | |||
| --checkbox-size: var(--cui-icon-sizes-mega); | |||
| --checkbox-size: 1.25rem; | |||
Contributor
There was a problem hiding this comment.
Should we do this to icons too ? Icons are usually aligned with text and I think they should scale too.
connor-baer
force-pushed
the
feat/brand-refresh-components
branch
from
14a5149 to
e70e50b
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #3424.
Approach and changes
--cui-border-radius-bitto 4px and increase--cui-border-radius-bitto 10pxDefinition of done