-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
fix: ensure effects destroy owned deriveds upon teardown #13563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: cd632e5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Mmm this could also in some way be related to #13586 ...could you take a look at that too? |
Rich-Harris
reviewed
Oct 14, 2024
Rich-Harris
approved these changes
Oct 14, 2024
This was referenced Oct 14, 2024
This was referenced Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deriveds now cleanup accordingly when the effect that they were created in gets destroyed. This should resolve a memory leak with deriveds that created in branch/root effects – and thus were previously never cleaned up as these effects don't know of the deriveds in the first place. This essentially aims to solve this memory leak:
Above the
double
derived leaks, with this PR we now destroy that derived when the{if}
block toggles. Previously, we didn't destroy it, meaning it was permanently retained forever – taking a lot of DOM and effects with it. This is because we read thedouble
inside the component body ofFoo.svelte
which is a branch effect – not a tracking effect. The read causes a connection to be made withcount
and this connection is never disconnected upon the effects being destroyed as the effects have no knowledge of the derived.