Skip to content

Update reserved word list to include local variable names in API methods #1824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 6, 2016

Conversation

wing328
Copy link
Contributor

@wing328 wing328 commented Jan 6, 2016

This PR will update the reserved word lists to include local variable names in API methods for Python, Ruby, PHP, C#, C#(.net 2.0), ObjC, TypeScript.

No need to update for Perl.

@wing328
Copy link
Contributor Author

wing328 commented Jan 6, 2016

Not sure why the CI failed with the following log:

$ javac -J-Xmx32m -version
javac 1.7.0_80
$ gem install bundler
Fetching: bundler-1.11.2.gem (100%)
Successfully installed bundler-1.11.2
1 gem installed
$ docker login --email=$DOCKER_HUB_EMAIL --username=$DOCKER_HUB_USERNAME --password=$DOCKER_HUB_PASSWORD
Username: 

No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.

The build has been terminated

Will take another look tomorrow.

@fehguy
Copy link
Contributor

fehguy commented Jan 6, 2016

Seems like travis is having troubles. I've confirmed these changes are building fine

fehguy added a commit that referenced this pull request Jan 6, 2016
Update reserved word list to include local variable names in API methods
@fehguy fehguy merged commit ab91fc8 into swagger-api:master Jan 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants