-
Notifications
You must be signed in to change notification settings - Fork 6k
CSharp client: optionally build .csproj file #1941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@jhancock93 thanks for the PR. It failed the generator test:
To run the CI test locally, please execute Let us know if you need help fixing the issue. |
@@ -62,4 +62,10 @@ | |||
public static final String OPTIONAL_ASSEMBLY_INFO = "optionalAssemblyInfo"; | |||
public static final String OPTIONAL_ASSEMBLY_INFO_DESC = "Generate AssemblyInfo.cs (Default: true)."; | |||
|
|||
public static final String OPTIONAL_PROJECT_FILE = "optionalProjectFile"; | |||
public static final String OPTIONAL_PROJECT_FILE_DESC = "Generate {PackageName}.csproj (Default: true)."; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a test and believe the default should be false, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct, the default should be false. Initially I had it default to true but forgot to change the description. I can fix that.
After setting I'm using Xamarin Studio 5.10 and Mono 4.2.1. Did you get similar error when opening the csproj file? |
No, I don't get the error you're seeing with the project file. I can open the .csproj file in VisualStudio with no errors. But I suppose we probably need a somewhat different template in Xamarin. I don't have Xamarin Studio myself, but I suspect the targets file or the TargetFrameworkVersion would be different with Xamarin. |
I've changed the following
to
and that works for me in Xamarin Studio Would that also work for you in Visual Studio? If yes, please update to use |
… option description
4.5 works for me. I've updated the branch with the code change to 4.5 and the correction on the default value in the option description. |
@jhancock93 thanks. PR merged |
CSharp client: optionally build .csproj file
@jhancock93 if you don't mind, I wonder if you can contact me via my personal email address in my Github profile page as I've 2 simple questions about your use case. |
Adds 2 parameters to csharp build options. One to control whether a project file is generated and another which can specify the Project Guid for the csproj.
Addresses open issue #1883.