Skip to content

Support file downloading in Java jersey2 client #1998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 31, 2016

Conversation

ww-mgr
Copy link
Contributor

@ww-mgr ww-mgr commented Jan 28, 2016

No description provided.

@wing328
Copy link
Contributor

wing328 commented Jan 28, 2016

@ww-mgr thanks for the PR. Do you mind updating the Petstore sample for Java Jersey2 API client as mentioned in the contributing guidelines?

@wing328 wing328 added this to the v2.1.6 milestone Jan 28, 2016
@ww-mgr
Copy link
Contributor Author

ww-mgr commented Jan 28, 2016

Sorry, I missed that part. I've updated the Petstore sample. All generated files have been changed because of the Generated annotation. It is better to commit only the relevant files next time?

@wing328
Copy link
Contributor

wing328 commented Jan 28, 2016

That's ok. To me, it's fine to commit those files with the timestamps updated in the annotation only.

@wing328
Copy link
Contributor

wing328 commented Jan 31, 2016

Test result looks good:

Tests run: 39, Failures: 0, Errors: 0, Skipped: 0

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 30.637 s
[INFO] Finished at: 2016-01-31T19:56:44+08:00
[INFO] Final Memory: 18M/245M
[INFO] ------------------------------------------------------------------------

wing328 added a commit that referenced this pull request Jan 31, 2016
Support file downloading in Java jersey2 client
@wing328 wing328 merged commit 0e0508c into swagger-api:master Jan 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants