Fix #1487, TypeScript-Angular output path wrong if apiPackage not the… #2076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…age not the default
|
@daveholladay thanks for the PR and sorry for taking a bit long to review. |
wing328
added a commit
that referenced
this pull request
Feb 15, 2016
Fix #1487, TypeScript-Angular output path wrong if apiPackage not the…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Typescript-Angular codegen added the api.d.mustache files in the constructor & picked up the output patch from the default value for apiPackage (API.Client).
Moving the add to the end of processOpts picks up the overridden value for apiPackage & outputs the file where it should be.
I've made the same change in Typescript-Node to avoid the same bug if the output is changed to fully qualified paths at a later date.