-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Command plugins should respect --build-system selection #8779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@swift-ci test |
6bf40c9
to
f1189f6
Compare
@swift-ci test |
f1189f6
to
6748a87
Compare
@swift-ci test |
@swift-ci test self-hosted |
This looks good to me. One of the test failures doesn't seem relevant to this change since it doesn't specify a command plugin and the native build system should be use implicitly. Maybe this is a transient failure of some sort.
The failure in PackageCommandNativeTests.testCommandPluginBuildingCallbacks with Windows appears to need a couple of pattern match adjustments to pass. |
It may have just been CI failing to trigger with the latest changes @swift-ci test |
6748a87
to
3ff8922
Compare
@swift-ci test |
@swift-ci test Windows |
@swift-ci test |
3ff8922
to
13e619b
Compare
@swift-ci test |
@swift-ci test Windows |
@swift-ci test macOS self hosted |
Windows had a network issue on the builder @swift-ci please test Windows |
@swift-ci test macOS |
@swift-ci test macOS |
Windows timed out @swift-ci test Windows |
Command plugins should use the user specified build system when building any dependencies, and if the command plugin requests a build of its own. Supporting the full range of command plugin functionality with the Swift Build backend will take a little more work, but this patch gets the fundamentals wired up
Command plugins should use the user specified build system when building any dependencies, and if the command plugin requests a build of its own. Supporting the full range of command plugin functionality with the Swift Build backend will take a little more work, but this patch gets the fundamentals wired up