Skip to content

Command plugins should respect --build-system selection #8779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2025

Conversation

owenv
Copy link
Contributor

@owenv owenv commented Jun 7, 2025

Command plugins should use the user specified build system when building any dependencies, and if the command plugin requests a build of its own. Supporting the full range of command plugin functionality with the Swift Build backend will take a little more work, but this patch gets the fundamentals wired up

@owenv
Copy link
Contributor Author

owenv commented Jun 7, 2025

@swift-ci test

@owenv owenv force-pushed the owenv/command-plugins branch from 6bf40c9 to f1189f6 Compare June 9, 2025 01:00
@owenv
Copy link
Contributor Author

owenv commented Jun 9, 2025

@swift-ci test

@owenv owenv force-pushed the owenv/command-plugins branch from f1189f6 to 6748a87 Compare June 9, 2025 01:45
@owenv
Copy link
Contributor Author

owenv commented Jun 9, 2025

@swift-ci test

@owenv
Copy link
Contributor Author

owenv commented Jun 9, 2025

@swift-ci test self-hosted

@cmcgee1024
Copy link
Member

This looks good to me. One of the test failures doesn't seem relevant to this change since it doesn't specify a command plugin and the native build system should be use implicitly. Maybe this is a transient failure of some sort.

✘ Test staticLibrary() recorded an issue at StaticBinaryLibrary.swift:20:6: Caught error: posix_spawn error: No such file or directory (2), `["cp", "-R", "-H", "/Users/ec2-user/jenkins/workspace/swift-package-manager-with-xcode-self-hosted-PR-osx-release-toolchain/branch-main/swiftpm/Fixtures/BinaryLibraries/Static", "/var/folders/bb/hcrjxg1s0b96pfst0ymhmp240000gn/T/BinaryLibraries.OgYWFQ/Static"]`

The failure in PackageCommandNativeTests.testCommandPluginBuildingCallbacks with Windows appears to need a couple of pattern match adjustments to pass.

@owenv
Copy link
Contributor Author

owenv commented Jun 9, 2025

It may have just been CI failing to trigger with the latest changes

@swift-ci test

@owenv owenv force-pushed the owenv/command-plugins branch from 6748a87 to 3ff8922 Compare June 9, 2025 16:58
@owenv
Copy link
Contributor Author

owenv commented Jun 9, 2025

@swift-ci test

@owenv
Copy link
Contributor Author

owenv commented Jun 9, 2025

@swift-ci test Windows

@owenv
Copy link
Contributor Author

owenv commented Jun 10, 2025

@swift-ci test

Unverified

The signing certificate or its chain could not be verified.
@owenv owenv force-pushed the owenv/command-plugins branch from 3ff8922 to 13e619b Compare June 10, 2025 17:39
@owenv
Copy link
Contributor Author

owenv commented Jun 10, 2025

@swift-ci test

@owenv
Copy link
Contributor Author

owenv commented Jun 10, 2025

@swift-ci test Windows

@owenv
Copy link
Contributor Author

owenv commented Jun 10, 2025

@swift-ci test macOS self hosted

@owenv
Copy link
Contributor Author

owenv commented Jun 10, 2025

Windows had a network issue on the builder

@swift-ci please test Windows

@owenv
Copy link
Contributor Author

owenv commented Jun 10, 2025

@swift-ci test macOS

@owenv
Copy link
Contributor Author

owenv commented Jun 11, 2025

@swift-ci test macOS

@owenv
Copy link
Contributor Author

owenv commented Jun 11, 2025

Windows timed out

@swift-ci test Windows

@owenv owenv merged commit 18f2018 into swiftlang:main Jun 11, 2025
6 checks passed
bripeticca pushed a commit to bripeticca/swift-package-manager that referenced this pull request Jun 17, 2025
Command plugins should use the user specified build system when building
any dependencies, and if the command plugin requests a build of its own.
Supporting the full range of command plugin functionality with the Swift
Build backend will take a little more work, but this patch gets the
fundamentals wired up
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants