[NFC] Name Binding -> Import Resolution #27998
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swift's NameBinding phase doesn't really perform name binding and hasn't for a really really long time. Rename this file to provide some clarity. Also rename performNameBinding to resolveImportsAndOperators
Remove the "private operator" bit from the map since import resolution wasn't actually using this.
A lot of places appear to mean "name lookup". A few places meant "import resolution".
Contributor
Author
|
@swift-ci please smoke test |
Contributor
Author
|
@swift-ci please test source compatibility |
Contributor
Author
|
Urf, need LLDB patches |
CodaFi
added a commit
to CodaFi/llvm-project
that referenced
this pull request
Oct 31, 2019
Contributor
Author
|
Jenkins died @swift-ci please test source compatibility |
Contributor
Author
|
@swift-ci please smoke test |
Contributor
Author
|
@swift-ci please smoke test macOS platform |
Contributor
Author
|
@swift-ci please test source compatibility |
Contributor
Author
|
Going to approach this a different way. Leaving the LLDB patch up for the future though... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename this phase to more accurately reflect the bulk of the work that it actually accomplishes, and to remove one more overload of the phrase "name binding" in the compiler. I've left the historical references to it alone, but a bunch of out of date doc comments are all updated to reflect the current state of the world.
This patch also has another NFC component that resolves an ancient FIXME around the extra bit in the maps we have for operators and precedence groups. It seems unused so I've removed it and simplified the two-phase lookup logic.