Skip to content

[Build] Pass the toolchain version through to Swift's compilation #82071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 9, 2025
Merged

[Build] Pass the toolchain version through to Swift's compilation #82071

merged 1 commit into from
Jun 9, 2025

Conversation

bnbarham
Copy link
Contributor

@bnbarham bnbarham commented Jun 6, 2025

Passes the value of the environment variable TOOLCHAIN_VERSION through to Swift's SWIFT_TOOLCHAIN_VERSION for use in eg. -print-target-info (and some day, --version).

@bnbarham bnbarham requested a review from shahmishal June 6, 2025 20:27
@bnbarham bnbarham requested a review from compnerd as a code owner June 6, 2025 20:27
@bnbarham
Copy link
Contributor Author

bnbarham commented Jun 6, 2025

@swift-ci please smoke test

@bnbarham
Copy link
Contributor Author

bnbarham commented Jun 6, 2025

@swift-ci please build toolchain

compnerd
compnerd approved these changes Jun 6, 2025
View reviewed changes
Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable enough to me.

@bnbarham bnbarham force-pushed the pass-through-toolchain-version branch from 2261761 to ebcb2e5 Compare June 6, 2025 20:40
@bnbarham
Copy link
Contributor Author

bnbarham commented Jun 6, 2025

@swift-ci please smoke test

@bnbarham
Copy link
Contributor Author

bnbarham commented Jun 6, 2025

@swift-ci please build toolchain

@bnbarham
[Build] Pass the toolchain version through to Swift's compilation
3982ebb 
Passes the value of the environment variable `TOOLCHAIN_VERSION` through
to Swift's `SWIFT_TOOLCHAIN_VERSION` for use in eg.
`-print-target-info` (and some day, `--version`).
@bnbarham bnbarham force-pushed the pass-through-toolchain-version branch from ebcb2e5 to 3982ebb Compare June 6, 2025 22:09
@bnbarham
Copy link
Contributor Author

bnbarham commented Jun 6, 2025

@swift-ci please smoke test

@bnbarham
Copy link
Contributor Author

bnbarham commented Jun 6, 2025

@swift-ci please build toolchain

@bnbarham
Copy link
Contributor Author

bnbarham commented Jun 7, 2025

@swift-ci please smoke test Linux platform

@bnbarham
Copy link
Contributor Author

bnbarham commented Jun 7, 2025

@swift-ci please build toolchain Windows platform

@bnbarham
Copy link
Contributor Author

bnbarham commented Jun 7, 2025 

swift-PR-82071-1982.xctoolchain/usr/bin/swift -print-target-info
{
  "compilerVersion": "Apple Swift version 6.2-dev (LLVM d135e8831f9d2d9, Swift 7739473af436bac)",
  "swiftCompilerTag": "swift-PR-82071-1982",
...

@bnbarham bnbarham merged commit 0afeafa into swiftlang:main Jun 9, 2025
6 checks passed
@bnbarham bnbarham deleted the pass-through-toolchain-version branch June 9, 2025 00:18
@bnbarham bnbarham mentioned this pull request Jun 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compnerd compnerd compnerd approved these changes

@shahmishal shahmishal shahmishal approved these changes

@etcwilde etcwilde Awaiting requested review from etcwilde etcwilde is a code owner

@justice-adams-apple justice-adams-apple Awaiting requested review from justice-adams-apple justice-adams-apple is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bnbarham @compnerd @shahmishal