Skip to content

[stdlib] fix utf8Span accessors for small strings #82077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 8, 2025

Conversation

glessard
Copy link
Contributor

@glessard glessard commented Jun 7, 2025

Re-implements the String.utf8Span and Substring.utf8Span accessors to properly return views on small (inline-stored) strings.

Addresses rdar://152615664 and #82024

@glessard glessard requested a review from a team as a code owner June 7, 2025 00:39
@glessard
Copy link
Contributor Author

glessard commented Jun 7, 2025

@swift-ci please test Linux platform

@glessard
Copy link
Contributor Author

glessard commented Jun 7, 2025

@swift-ci please smoke test macOS platform

@glessard
Copy link
Contributor Author

glessard commented Jun 7, 2025

@swift-ci please test Windows platform

@glessard glessard requested a review from atrick June 7, 2025 00:46
Copy link
Contributor

@atrick atrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@glessard glessard changed the title [test] fix utf8Span accessors for small strings [stdlib] fix utf8Span accessors for small strings Jun 7, 2025
@glessard
Copy link
Contributor Author

glessard commented Jun 7, 2025

@swift-ci please smoke test macOS platform

@glessard
Copy link
Contributor Author

glessard commented Jun 7, 2025

@swift-ci please test Linux platform

@glessard
Copy link
Contributor Author

glessard commented Jun 7, 2025

@swift-ci please test

@glessard glessard enabled auto-merge June 7, 2025 14:52
@glessard glessard disabled auto-merge June 7, 2025 14:52
@glessard
Copy link
Contributor Author

glessard commented Jun 8, 2025

@swift-ci please test Linux platform

@glessard
Copy link
Contributor Author

glessard commented Jun 8, 2025

@swift-ci please smoke test macOS platform

@glessard glessard merged commit 2afb6b5 into swiftlang:main Jun 8, 2025
4 of 5 checks passed
@glessard glessard deleted the issue81931 branch June 10, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants