Skip to content

[6.2][ScanDependencies] Fix a bug in rewrite from #81454 #82642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

cachemeifyoucan
Copy link
Contributor

  • Explanation: In the previous rewrite to speed to bridging clang dependency scanning, it causes a regression that -ivfsoverlay arguments are dropped from -emit-pcm jobs. This can sometimes cause build failure due to VFS overlay are not overlaying existing files on the file system.
  • Scope: Regression fix for unintended functional change and potential build failures.
  • Issues: rdar://153851818
  • Original PRs: [ScanDependencies] Fix a bug in rewrite from #81454 #82608
  • Risk: Low. Restore to old behavior
  • Testing: Improved unit testing that covers VFS overlaying on top of existing files.
  • Reviewers: @artemcm

When improving the speed of dependency scanning when the new clang API
to speed up bridging, some unintended change was introduced. This
restore the scanner to the behavior before swiftlang#81454

rdar://153851818
(cherry picked from commit cebe173)
@cachemeifyoucan cachemeifyoucan requested a review from a team as a code owner June 30, 2025 17:56
@cachemeifyoucan
Copy link
Contributor Author

@swift-ci please test

Copy link
Contributor

@nkcsgexi nkcsgexi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preserving additional compiler arguments when scanning dependencies should be a safe change.

@cachemeifyoucan
Copy link
Contributor Author

@swift-ci please test macOS platform

@cachemeifyoucan cachemeifyoucan merged commit 7606a69 into swiftlang:release/6.2 Jul 1, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants