[6.2][Concurrency] Forego Sendable checking if conversion doesn't change t… #82675
+23
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he global actor `FunctionConversionExpr` is allowed to modify different attributes of a type, sometimes it could strip `@Sendable` but keep the same global actor attribute in place, that needs to be handled explicitly before performing Sendable checking because in this case there is going to be no isolation context change for arguments or results. Resolves: rdar://153646123 (cherry picked from commit 053199e)
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
bnbarham
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…he global actor
Explanation:
FunctionConversionExpris allowed to modify different attributes of a type, sometimes it could strip@Sendablebut keep the same global actor attribute in place, that needs to be handled explicitly before performing Sendable checking because in this case there is going to be no isolation context change for arguments or results.Resolves: rdar://153646123
Main Branch PR: [Concurrency] Forego Sendable checking if conversion doesn't change t… #82645
Risk: Very Low. A small tweak to a check where both from and to function types have a global actor isolation in a function conversion expression.
Reviewed By: @ktoso
Testing: Added new test-cases to the test suite.
(cherry picked from commit 053199e)