[6.2][Serialization] A temporary fix for LocatableType
#82676
Merged
+34
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gracefully handle `LocatableType` types if they show up during serialization. This is a temporary fix until we can remove `TransitivelyConformsTo` constraint from the solver which is the underlying cause of the issue (see swiftlang#82541). Resolves: rdar://153461854 (cherry picked from commit 907606e)
|
@swift-ci please test |
bnbarham
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation:
Gracefully handle
LocatableTypetypes if they show up during serialization.This is a temporary fix until we can remove
TransitivelyConformsToconstraintfrom the solver which is the underlying cause of the issue (see [CSSimplify] Skip transitive conformance check if argument is
CGFloatorDouble#82541).Resolves: rdar://153461854
Main Branch PR: [Serialization] A temporary fix for
LocatableType#82652Risk: Very Low. A narrow fix when
LocatableTypesurvives until serialization (look through it because it's transparent for anything but expression diagnostics).Reviewed By: @xymus
Testing: Added new test-cases to the test suite.
(cherry picked from commit 907606e)