Fix incorrectly setting cancelled futures#44
Merged
markedwards merged 3 commits intosyrusakbary:masterfrom Feb 12, 2025
Merged
Conversation
Author
|
@syrusakbary There seems to be an issue with branch checks, I'm unsure what's he next step. |
Collaborator
|
This generally looks good. You have some type errors in |
Author
|
I've just fixed the type errors, let me know if there's anything else I can help with. |
Collaborator
|
I have updated GitHub actions, please update and re-trigger CI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
I'm running
aiodataloaderin production, not in a GraphQL context, but in a concurrent message consumer. Some messages consumed in the same event loop iteration may refer to the same data, and an uncachedDataLoaderhelps with the IO load.When the connection to the message broker drops, the current message handling tasks will get cancelled.
This leads to this typical log message:
It turns out
aiodataloaderis not checking if anasyncio.Futureis not already cancelled before attempting to set it, which is againstasynciorecommended practice.This PR enforces this check for all
asyncio.Futureset byaiodataloader.