Move appUiStructure and scenarioGenerationCustomInstruction into prompt in yaml

[takahirom]

No description provided.

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes consolidate the management of appUiStructure and scenarioGenerationCustomInstruction properties from separate locations into a unified structure. These properties are moved from the ArbigentProjectSettings class into the nested ArbigentPrompt class, with deprecated computed properties left in ArbigentProjectSettings for backward compatibility. In the UI state holder, separate flows for these properties are removed, and updates now occur directly within the promptFlow. Correspondingly, UI components now initialize and interact with these properties through the consolidated promptFlow rather than individual flows.

Changes

File(s)	Change Summary
arbigent-core/src/main/java/io/github/takahirom/arbigent/ArbigentProjectSerializer.kt	Moved appUiStructure and scenarioGenerationCustomInstruction from ArbigentProjectSettings to ArbigentPrompt; added deprecated computed properties for backward compatibility.
arbigent-ui/src/main/kotlin/io/github/takahirom/arbigent/ui/ArbigentAppStateHolder.kt	Removed separate flows for appUiStructure and scenarioGenerationCustomInstruction; updated methods to modify promptFlow instead.
arbigent-ui/src/main/kotlin/io/github/takahirom/arbigent/ui/ScenarioGenerationDialog.kt	Changed initialization of text fields to use values from promptFlow instead of separate flows.

Sequence Diagram(s)

sequenceDiagram
    participant UI as ScenarioGenerationDialog
    participant State as ArbigentAppStateHolder
    participant Core as ArbigentPrompt

    UI->>State: onAppUiStructureChanged(newStructure)
    State->>Core: promptFlow = promptFlow.copy(appUiStructure = newStructure)

    UI->>State: onScenarioGenerationCustomInstructionChanged(newInstruction)
    State->>Core: promptFlow = promptFlow.copy(scenarioGenerationCustomInstruction = newInstruction)

    UI->>State: Read promptFlow.value.appUiStructure / scenarioGenerationCustomInstruction

Loading

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6b94ff9 and 1771336.

📒 Files selected for processing (3)

• arbigent-core/src/main/java/io/github/takahirom/arbigent/ArbigentProjectSerializer.kt (2 hunks)
• arbigent-ui/src/main/kotlin/io/github/takahirom/arbigent/ui/ArbigentAppStateHolder.kt (3 hunks)
• arbigent-ui/src/main/kotlin/io/github/takahirom/arbigent/ui/ScenarioGenerationDialog.kt (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (11)

• GitHub Check: build (windows-latest)
• GitHub Check: build
• GitHub Check: cli-e2e-android (2, 2)
• GitHub Check: build (macos-13)
• GitHub Check: build (macos-latest)
• GitHub Check: cli-e2e-ios
• GitHub Check: cli-e2e-android (1, 2)
• GitHub Check: test
• GitHub Check: build (ubuntu-latest)
• GitHub Check: compare-screenshot-test
• GitHub Check: store-screenshot-test

🔇 Additional comments (8)

arbigent-ui/src/main/kotlin/io/github/takahirom/arbigent/ui/ScenarioGenerationDialog.kt (2)

40-40: Good change - initializing from the consolidated prompt structure

The initialization of appUiStructure now correctly retrieves its value from the consolidated promptFlow.value.appUiStructure instead of a separate flow.

---

43-43: Good change - initializing from the consolidated prompt structure

The initialization of customInstruction now correctly retrieves its value from the consolidated promptFlow.value.scenarioGenerationCustomInstruction instead of a separate flow.

arbigent-core/src/main/java/io/github/takahirom/arbigent/ArbigentProjectSerializer.kt (2)

109-117: Good use of deprecated properties for backward compatibility

The implementation of backward compatibility using deprecated properties is well done. The deprecated properties delegate to the new location in the prompt field, ensuring a smooth transition for any existing code.

---

127-131: Correctly moved properties with appropriate YAML annotations

The properties have been correctly moved to the ArbigentPrompt class with appropriate YAML multiline string annotations to maintain the same serialization format.

arbigent-ui/src/main/kotlin/io/github/takahirom/arbigent/ui/ArbigentAppStateHolder.kt (4)

176-180: LGTM - Using consolidated prompt structure

The property access has been correctly updated to use the consolidated prompt structure when creating an ArbigentProjectSettings instance.

---

269-273: LGTM - Using consolidated prompt structure

The property access has been correctly updated to use the consolidated prompt structure when saving project contents.

---

398-398: Good refactoring of state updates

The onAppUiStructureChanged method now correctly updates the property within the promptFlow instead of updating a separate flow, aligning with the consolidated state management approach.

---

402-402: Good refactoring of state updates

The onScenarioGenerationCustomInstructionChanged method now correctly updates the property within the promptFlow instead of updating a separate flow, aligning with the consolidated state management approach.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.