Skip to content

feat(linux): allow disabling WebViewUriLoader via feature #1562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

dgerhardt
Copy link

@dgerhardt dgerhardt commented Jun 3, 2025

A new feature flag linux-request-queue has been introduced, which is enabled by default to keep the previous behavior.

The WebViewUriLoader is a workaround for an unknown bug but disabling it can be useful because

  • it introduces a deadlock situation, and
  • the bug might no longer exist in newer WebKitGTK versions.

Refs tauri-apps/tauri#12589
Refs #359

@dgerhardt dgerhardt requested a review from a team as a code owner June 3, 2025 17:53
@dgerhardt dgerhardt force-pushed the linux-request-queue-feature branch from 0e9f281 to a262a4b Compare June 3, 2025 17:58
Copy link
Contributor

github-actions bot commented Jun 3, 2025

Package Changes Through a262a4b

There are 1 changes which include wry with minor

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
wry 0.51.2 0.52.0

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

A new feature flag `linux-request-queue` has been introduced, which is
enabled by default to keep the previous behavior.

The `WebViewUriLoader` is a workaround for an unknown bug but disabling
it can be useful because
* it introduces a deadlock situation, and
* the bug might no longer exist in newer WebKitGTK versions.

Refs tauri-apps/tauri#12589
Refs tauri-apps#359
@dgerhardt dgerhardt force-pushed the linux-request-queue-feature branch from a262a4b to d16c451 Compare June 24, 2025 09:29
@dgerhardt
Copy link
Author

@chippers @wusyong Could you have a look at this PR? It is related to a workaround introduced with #359, which you submitted/reviewed.

@lucasfernog
Copy link
Member

shouldn't this be done via a configuration in the webview attributes instead of a feature flag?

@lucasfernog
Copy link
Member

it's also a pretty feature creepy config anyway

@dgerhardt
Copy link
Author

@lucasfernog I've used a feature under the assumption that the marked code is a preparation for a complete removal in the future when the underlying Webkit2GTK issue has been fixed.

If you think that a webview attribute would be more appropriate in this case, I'm happy to adjust the PR.

@dgerhardt
Copy link
Author

I had a look at implementing this using PlatformSpecificWebViewAttributes. I might be missing something, but I don't see a way to override the attribute defaults for webviews on the application side. It wouldn't make much sense to pass the setting to every single webview on creation since you would either globally enable or disable the workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants