-
Notifications
You must be signed in to change notification settings - Fork 491
merge immutable-arraybuffer tests #4445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
phoddie
wants to merge
11
commits into
tc39:main
Choose a base branch
from
Moddable-OpenSource:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
b77ff72
merge immutable-arraybuffer tests
phoddie de639e5
Merge branch 'tc39:main' into main
phoddie 36b12c8
simplify copyright date
phoddie da62d98
add immutable-arraybuffer
phoddie ebe1d11
descriptions
phoddie 430c4fe
two more descriptions
phoddie 3cc1fd6
esid
phoddie bfcb1fc
typo
phoddie 6620a1d
that kind of day
phoddie 198aafd
apply feedback from @anba
phoddie 517c9e3
resolve upsert conflict
phoddie File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 changes: 23 additions & 0 deletions
23
test/built-ins/ArrayBuffer/prototype/immutable/immutable-buffer.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
// Copyright (C) 2025 Moddable Tech, Inc. All rights reserved. | ||
// This code is governed by the BSD license found in the LICENSE file. | ||
/*--- | ||
description: verify immutable property of ArrayBuffer | ||
esid: sec-get-arraybuffer.prototype.immutable | ||
features: [ArrayBuffer, immutable-arraybuffer] | ||
---*/ | ||
|
||
var ab = new ArrayBuffer(1); | ||
|
||
assert.sameValue(ab.immutable, false); | ||
|
||
ab = ab.transferToImmutable(); | ||
|
||
assert.sameValue(ab.immutable, true); | ||
|
||
ab = new ArrayBuffer(1, { maxByteLength: 2 }); | ||
|
||
assert.sameValue(ab.immutable, false); | ||
|
||
ab = ab.transferToImmutable(); | ||
|
||
assert.sameValue(ab.immutable, true); |
11 changes: 11 additions & 0 deletions
11
test/built-ins/ArrayBuffer/prototype/immutable/invoked-as-accessor.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
// Copyright (C) 2025 Moddable Tech, Inc. All rights reserved. | ||
// This code is governed by the BSD license found in the LICENSE file. | ||
/*--- | ||
description: verify immutable property requires ArrayBuffer receiver | ||
esid: sec-get-arraybuffer.prototype.immutable | ||
features: [ArrayBuffer, immutable-arraybuffer] | ||
---*/ | ||
|
||
assert.throws(TypeError, function() { | ||
ArrayBuffer.prototype.immutable; | ||
}); |
17 changes: 17 additions & 0 deletions
17
test/built-ins/ArrayBuffer/prototype/immutable/invoked-as-func.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
// Copyright (C) 2025 Moddable Tech, Inc. All rights reserved. | ||
// This code is governed by the BSD license found in the LICENSE file. | ||
/*--- | ||
description: verify immutable property is implemented by an accessor | ||
esid: sec-get-arraybuffer.prototype.immutable | ||
features: [ArrayBuffer, immutable-arraybuffer] | ||
---*/ | ||
|
||
var getter = Object.getOwnPropertyDescriptor( | ||
ArrayBuffer.prototype, 'immutable' | ||
).get; | ||
|
||
assert.sameValue(typeof getter, 'function'); | ||
|
||
assert.throws(TypeError, function() { | ||
getter(); | ||
}); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
// Copyright (C) 2025 Moddable Tech, Inc. All rights reserved. | ||
// This code is governed by the BSD license found in the LICENSE file. | ||
/*--- | ||
description: verify immutable getter's length property attributes and value | ||
esid: sec-get-arraybuffer.prototype.immutable | ||
includes: [propertyHelper.js] | ||
features: [ArrayBuffer, immutable-arraybuffer] | ||
---*/ | ||
|
||
var desc = Object.getOwnPropertyDescriptor(ArrayBuffer.prototype, 'immutable'); | ||
|
||
verifyProperty(desc.get, 'length', { | ||
value: 0, | ||
enumerable: false, | ||
writable: false, | ||
configurable: true | ||
}); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
// Copyright (C) 2025 Moddable Tech, Inc. All rights reserved. | ||
// This code is governed by the BSD license found in the LICENSE file. | ||
/*--- | ||
description: verify immutable getter's name property attributes and value | ||
esid: sec-get-arraybuffer.prototype.immutable | ||
includes: [propertyHelper.js] | ||
features: [ArrayBuffer, immutable-arraybuffer] | ||
---*/ | ||
|
||
var desc = Object.getOwnPropertyDescriptor(ArrayBuffer.prototype, 'immutable'); | ||
|
||
verifyProperty(desc.get, 'name', { | ||
value: 'get immutable', | ||
enumerable: false, | ||
writable: false, | ||
configurable: true | ||
}); |
18 changes: 18 additions & 0 deletions
18
test/built-ins/ArrayBuffer/prototype/immutable/prop-desc.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
// Copyright (C) 2025 Moddable Tech, Inc. All rights reserved. | ||
// This code is governed by the BSD license found in the LICENSE file. | ||
/*--- | ||
description: immutable property has no setter | ||
esid: sec-get-arraybuffer.prototype.immutable | ||
includes: [propertyHelper.js] | ||
features: [ArrayBuffer, immutable-arraybuffer] | ||
---*/ | ||
|
||
var desc = Object.getOwnPropertyDescriptor(ArrayBuffer.prototype, 'immutable'); | ||
|
||
assert.sameValue(desc.set, undefined); | ||
assert.sameValue(typeof desc.get, 'function'); | ||
|
||
verifyProperty(ArrayBuffer.prototype, 'immutable', { | ||
enumerable: false, | ||
configurable: true | ||
}); |
31 changes: 31 additions & 0 deletions
31
test/built-ins/ArrayBuffer/prototype/immutable/this-has-no-arraybufferdata-internal.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
// Copyright (C) 2025 Moddable Tech, Inc. All rights reserved. | ||
// This code is governed by the BSD license found in the LICENSE file. | ||
/*--- | ||
description: immmutable getter is a function that throws if receiver is not an ArrayBuffer | ||
esid: sec-get-arraybuffer.prototype.immutable | ||
features: [DataView, Int8Array, ArrayBuffer, immutable-arraybuffer] | ||
---*/ | ||
|
||
var getter = Object.getOwnPropertyDescriptor( | ||
ArrayBuffer.prototype, "immutable" | ||
).get; | ||
|
||
assert.sameValue(typeof getter, "function"); | ||
|
||
assert.throws(TypeError, function() { | ||
getter.call({}); | ||
}); | ||
|
||
assert.throws(TypeError, function() { | ||
getter.call([]); | ||
}); | ||
|
||
var ta = new Int8Array(8); | ||
assert.throws(TypeError, function() { | ||
getter.call(ta); | ||
}); | ||
|
||
var dv = new DataView(new ArrayBuffer(8), 0); | ||
assert.throws(TypeError, function() { | ||
getter.call(dv); | ||
}); |
42 changes: 42 additions & 0 deletions
42
test/built-ins/ArrayBuffer/prototype/immutable/this-is-not-object.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
// Copyright (C) 2025 Moddable Tech, Inc. All rights reserved. | ||
// This code is governed by the BSD license found in the LICENSE file. | ||
/*--- | ||
description: immutable getter throws if this is not an Object | ||
esid: sec-get-arraybuffer.prototype.immutable | ||
features: [Symbol, ArrayBuffer, immutable-arraybuffer] | ||
---*/ | ||
|
||
var getter = Object.getOwnPropertyDescriptor( | ||
ArrayBuffer.prototype, "immutable" | ||
).get; | ||
|
||
assert.sameValue(typeof getter, "function"); | ||
|
||
assert.throws(TypeError, function() { | ||
getter.call(undefined); | ||
}, "this is undefined"); | ||
|
||
assert.throws(TypeError, function() { | ||
getter.call(null); | ||
}, "this is null"); | ||
|
||
assert.throws(TypeError, function() { | ||
getter.call(42); | ||
}, "this is 42"); | ||
|
||
assert.throws(TypeError, function() { | ||
getter.call("1"); | ||
}, "this is a string"); | ||
|
||
assert.throws(TypeError, function() { | ||
getter.call(true); | ||
}, "this is true"); | ||
|
||
assert.throws(TypeError, function() { | ||
getter.call(false); | ||
}, "this is false"); | ||
|
||
var s = Symbol("s"); | ||
assert.throws(TypeError, function() { | ||
getter.call(s); | ||
}, "this is a Symbol"); |
20 changes: 20 additions & 0 deletions
20
test/built-ins/ArrayBuffer/prototype/immutable/this-is-sharedarraybuffer-resizable.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
// Copyright (C) 2025 Moddable Tech, Inc. All rights reserved. | ||
// This code is governed by the BSD license found in the LICENSE file. | ||
/*--- | ||
description: immutable getter throws if receiver is growable SharedArrayBuffer | ||
esid: sec-get-arraybuffer.prototype.immutable | ||
features: [SharedArrayBuffer, ArrayBuffer, immutable-arraybuffer] | ||
---*/ | ||
|
||
var immutable = Object.getOwnPropertyDescriptor( | ||
ArrayBuffer.prototype, "immutable" | ||
); | ||
|
||
var getter = immutable.get; | ||
var sab = new SharedArrayBuffer(4, {maxByteLength: 20}); | ||
|
||
assert.sameValue(typeof getter, "function"); | ||
|
||
assert.throws(TypeError, function() { | ||
getter.call(sab); | ||
}, "`this` cannot be a SharedArrayBuffer"); |
20 changes: 20 additions & 0 deletions
20
test/built-ins/ArrayBuffer/prototype/immutable/this-is-sharedarraybuffer.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
@@ -0,0 +1,20 @@ | ||||||||||||||||||||
// Copyright (C) 2025 Moddable Tech, Inc. All rights reserved. | ||||||||||||||||||||
// This code is governed by the BSD license found in the LICENSE file. | ||||||||||||||||||||
/*--- | ||||||||||||||||||||
description: immutable getter throws if this is a SharedArrayBuffer | ||||||||||||||||||||
esid: sec-get-arraybuffer.prototype.immutable | ||||||||||||||||||||
features: [SharedArrayBuffer, ArrayBuffer, immutable-arraybuffer] | ||||||||||||||||||||
---*/ | ||||||||||||||||||||
|
||||||||||||||||||||
var immutable = Object.getOwnPropertyDescriptor( | ||||||||||||||||||||
ArrayBuffer.prototype, "immutable" | ||||||||||||||||||||
); | ||||||||||||||||||||
|
||||||||||||||||||||
var getter = immutable.get; | ||||||||||||||||||||
Comment on lines
+9
to
+13
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nit:
Suggested change
|
||||||||||||||||||||
var sab = new SharedArrayBuffer(4); | ||||||||||||||||||||
|
||||||||||||||||||||
assert.sameValue(typeof getter, "function"); | ||||||||||||||||||||
|
||||||||||||||||||||
assert.throws(TypeError, function() { | ||||||||||||||||||||
getter.call(sab); | ||||||||||||||||||||
}, "`this` cannot be a SharedArrayBuffer"); |
14 changes: 14 additions & 0 deletions
14
test/built-ins/ArrayBuffer/prototype/transferToImmutable/descriptor.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
// Copyright (C) 2025 Moddable Tech, Inc. All rights reserved. | ||
// This code is governed by the BSD license found in the LICENSE file. | ||
/*--- | ||
description: verify transferToImmutable property attributes | ||
esid: sec-arraybuffer.prototype.transfertoimmutable | ||
includes: [propertyHelper.js] | ||
features: [immutable-arraybuffer] | ||
---*/ | ||
|
||
verifyProperty(ArrayBuffer.prototype, 'transferToImmutable', { | ||
enumerable: false, | ||
writable: true, | ||
configurable: true | ||
}); |
9 changes: 9 additions & 0 deletions
9
test/built-ins/ArrayBuffer/prototype/transferToImmutable/extensible.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
// Copyright (C) 2025 Moddable Tech, Inc. All rights reserved. | ||
// This code is governed by the BSD license found in the LICENSE file. | ||
/*--- | ||
description: transferToImmutable is extensible | ||
esid: sec-arraybuffer.prototype.transfertoimmutable | ||
features: [immutable-arraybuffer] | ||
---*/ | ||
|
||
assert(Object.isExtensible(ArrayBuffer.prototype.transferToImmutable)); |
33 changes: 33 additions & 0 deletions
33
test/built-ins/ArrayBuffer/prototype/transferToImmutable/from-fixed-to-larger.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
// Copyright (C) 2025 Moddable Tech, Inc. All rights reserved. | ||
// This code is governed by the BSD license found in the LICENSE file. | ||
/*--- | ||
description: transfer ArrayBuffer to larger immutable ArrayBuffer | ||
esid: sec-arraybuffer.prototype.transfertoimmutable | ||
features: [resizable-arraybuffer, immutable-arraybuffer] | ||
---*/ | ||
|
||
var source = new ArrayBuffer(4); | ||
|
||
var sourceArray = new Uint8Array(source); | ||
sourceArray[0] = 1; | ||
sourceArray[1] = 2; | ||
sourceArray[2] = 3; | ||
sourceArray[3] = 4; | ||
|
||
var dest = source.transferToImmutable(5); | ||
|
||
assert.sameValue(source.byteLength, 0, 'source.byteLength'); | ||
assert.sameValue(source.detached, true, 'source.byteLength'); | ||
|
||
assert.sameValue(dest.immutable, true, 'dest.immutable'); | ||
assert.sameValue(dest.resizable, false, 'dest.resizable'); | ||
assert.sameValue(dest.byteLength, 5, 'dest.byteLength'); | ||
assert.sameValue(dest.maxByteLength, 5, 'dest.maxByteLength'); | ||
|
||
var destArray = new Uint8Array(dest); | ||
|
||
assert.sameValue(destArray[0], 1, 'destArray[0]'); | ||
assert.sameValue(destArray[1], 2, 'destArray[1]'); | ||
assert.sameValue(destArray[2], 3, 'destArray[2]'); | ||
assert.sameValue(destArray[3], 4, 'destArray[3]'); | ||
assert.sameValue(destArray[4], 0, 'destArray[4]'); |
32 changes: 32 additions & 0 deletions
32
test/built-ins/ArrayBuffer/prototype/transferToImmutable/from-fixed-to-same.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
// Copyright (C) 2025 Moddable Tech, Inc. All rights reserved. | ||
// This code is governed by the BSD license found in the LICENSE file. | ||
/*--- | ||
description: transfer ArrayBuffer to same size immutable ArrayBuffer | ||
esid: sec-arraybuffer.prototype.transfertoimmutable | ||
features: [resizable-arraybuffer, immutable-arraybuffer] | ||
---*/ | ||
|
||
var source = new ArrayBuffer(4); | ||
|
||
var sourceArray = new Uint8Array(source); | ||
sourceArray[0] = 1; | ||
sourceArray[1] = 2; | ||
sourceArray[2] = 3; | ||
sourceArray[3] = 4; | ||
|
||
var dest = source.transferToImmutable(); | ||
|
||
assert.sameValue(source.byteLength, 0, 'source.byteLength'); | ||
assert.sameValue(source.detached, true, 'source.byteLength'); | ||
|
||
assert.sameValue(dest.immutable, true, 'dest.immutable'); | ||
assert.sameValue(dest.resizable, false, 'dest.resizable'); | ||
assert.sameValue(dest.byteLength, 4, 'dest.byteLength'); | ||
assert.sameValue(dest.maxByteLength, 4, 'dest.maxByteLength'); | ||
|
||
var destArray = new Uint8Array(dest); | ||
|
||
assert.sameValue(destArray[0], 1, 'destArray[0]'); | ||
assert.sameValue(destArray[1], 2, 'destArray[1]'); | ||
assert.sameValue(destArray[2], 3, 'destArray[2]'); | ||
assert.sameValue(destArray[3], 4, 'destArray[3]'); |
31 changes: 31 additions & 0 deletions
31
test/built-ins/ArrayBuffer/prototype/transferToImmutable/from-fixed-to-smaller.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
// Copyright (C) 2025 Moddable Tech, Inc. All rights reserved. | ||
// This code is governed by the BSD license found in the LICENSE file. | ||
/*--- | ||
description: transfer ArrayBuffer to smaller immutable ArrayBuffer | ||
esid: sec-arraybuffer.prototype.transfertoimmutable | ||
features: [resizable-arraybuffer, immutable-arraybuffer] | ||
---*/ | ||
|
||
var source = new ArrayBuffer(4); | ||
|
||
var sourceArray = new Uint8Array(source); | ||
sourceArray[0] = 1; | ||
sourceArray[1] = 2; | ||
sourceArray[2] = 3; | ||
sourceArray[3] = 4; | ||
|
||
var dest = source.transferToImmutable(3); | ||
|
||
assert.sameValue(source.byteLength, 0, 'source.byteLength'); | ||
assert.sameValue(source.detached, true, 'source.byteLength'); | ||
|
||
assert.sameValue(dest.immutable, true, 'dest.immutable'); | ||
assert.sameValue(dest.resizable, false, 'dest.resizable'); | ||
assert.sameValue(dest.byteLength, 3, 'dest.byteLength'); | ||
assert.sameValue(dest.maxByteLength, 3, 'dest.maxByteLength'); | ||
|
||
var destArray = new Uint8Array(dest); | ||
|
||
assert.sameValue(destArray[0], 1, 'destArray[0]'); | ||
assert.sameValue(destArray[1], 2, 'destArray[1]'); | ||
assert.sameValue(destArray[2], 3, 'destArray[2]'); |
25 changes: 25 additions & 0 deletions
25
test/built-ins/ArrayBuffer/prototype/transferToImmutable/from-fixed-to-zero.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
// Copyright (C) 2025 Moddable Tech, Inc. All rights reserved. | ||
// This code is governed by the BSD license found in the LICENSE file. | ||
/*--- | ||
description: transfer ArrayBuffer to zero length immutable ArrayBuffer | ||
esid: sec-arraybuffer.prototype.transfertoimmutable | ||
features: [resizable-arraybuffer, immutable-arraybuffer] | ||
---*/ | ||
|
||
var source = new ArrayBuffer(4); | ||
|
||
var sourceArray = new Uint8Array(source); | ||
sourceArray[0] = 1; | ||
sourceArray[1] = 2; | ||
sourceArray[2] = 3; | ||
sourceArray[3] = 4; | ||
|
||
var dest = source.transferToImmutable(0); | ||
|
||
assert.sameValue(source.byteLength, 0, 'source.byteLength'); | ||
assert.sameValue(source.detached, true, 'source.byteLength'); | ||
|
||
assert.sameValue(dest.immutable, true, 'dest.immutable'); | ||
assert.sameValue(dest.resizable, false, 'dest.resizable'); | ||
assert.sameValue(dest.byteLength, 0, 'dest.byteLength'); | ||
assert.sameValue(dest.maxByteLength, 0, 'dest.maxByteLength'); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: