add git_lock_timeout in values.yml and make the builder-deployment.ya…#61
Closed
robinmonjo wants to merge 1 commit into
Closed
add git_lock_timeout in values.yml and make the builder-deployment.ya…#61robinmonjo wants to merge 1 commit into
robinmonjo wants to merge 1 commit into
Conversation
Cryptophobia
requested changes
Jan 30, 2020
Member
There was a problem hiding this comment.
Thanks @robinmonjo ! This is a great change. Thank you for opening the PR.
Just one small change request, could you reformat the commit msg so it follows this style:
https://docs.teamhephy.com/contributing/submitting-a-pull-request/#commit-style
Something like this would work out perfectly for our release tool:
"feat(values): add git_lock_timeout in values.yml for builder"
kingdonb
pushed a commit
to kingdonb/builder
that referenced
this pull request
Feb 1, 2020
Add git_lock_timeout in values.yml and make the builder-deployment.yaml use it. closes teamhephy#61
Member
kingdonb
pushed a commit
to kingdonb/builder
that referenced
this pull request
Feb 1, 2020
Add git_lock_timeout in values.yml and make the builder-deployment.yaml use it. closes teamhephy#61
Member
|
Merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ml use it
If your change requires any additions or changes to the documentation or to the end-to-end test suite, please submit them as 1 or more pull requests against that repo and refer to them here.