Fix for refreshing of objectstorage-keyfile#10
Merged
Cryptophobia merged 2 commits intoOct 20, 2020
Conversation
Signed-off-by: Cryptophobia <aouzounov@gmail.com>
Cryptophobia
force-pushed
the
issue/fix-objecstorage-keyfile-in-namespaces
branch
from
18c75ce to
ec87381
Compare
…torage-keyfile-in-namespaces
duanhongyi
added a commit
to duanhongyi/controller
that referenced
this pull request
Jan 3, 2021
feat(controller): add a volume command
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the fix for the bug #9 which affects objectstorage-keyfile secrets in application namespaces. With this fix, the controller will copy the objecstorage-keyfile from the main
deisworkflow namespace and existing buildpack applications will have fresh objectstorage-keyfile secret when their configuration changes or when they are deployed by the controller because the controller will now check if the objectstorage-keyfile has changed. New buildpack applications always get the latest objectstorage-keyfile so that has not changed. 👍All tests should pass.
It was tested in a live production workflow build with many applications.