Skip to content

fix(charts): set rbac apiVersion without casting#10

Merged
Cryptophobia merged 1 commit into
teamhephy:masterfrom
Cryptophobia:master
Aug 9, 2018
Merged

fix(charts): set rbac apiVersion without casting#10
Cryptophobia merged 1 commit into
teamhephy:masterfrom
Cryptophobia:master

Conversation

@Cryptophobia
Copy link
Copy Markdown
Member

This fixes what we experiencing on GKE testing today where kubeVersions can be 1.9+ and our helm int casting fails.

Thanks to prometheus-operator for the idea: prometheus-operator/prometheus-operator#1729

@Cryptophobia Cryptophobia requested a review from kingdonb August 8, 2018 16:20
Copy link
Copy Markdown
Member

@kingdonb kingdonb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cryptophobia Cryptophobia merged commit d094f5f into teamhephy:master Aug 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants