Skip to content

chore(minio): upgrading to the latest release#7

Merged
Cryptophobia merged 1 commit into
teamhephy:masterfrom
kingdonb:master
Feb 13, 2019
Merged

chore(minio): upgrading to the latest release#7
Cryptophobia merged 1 commit into
teamhephy:masterfrom
kingdonb:master

Conversation

@kingdonb
Copy link
Copy Markdown
Member

@kingdonb kingdonb commented Feb 11, 2019

For #6

@kingdonb kingdonb mentioned this pull request Feb 11, 2019
@Cryptophobia
Copy link
Copy Markdown
Member

Alright, I will merge this in right after you let me know how the test went. 👍

@Cryptophobia Cryptophobia self-requested a review February 11, 2019 22:54
Copy link
Copy Markdown
Member

@Cryptophobia Cryptophobia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kingdonb
Copy link
Copy Markdown
Member Author

This is tested and works OK. I did not deal with the migration stuff, there may not even be any need.

I'll look into it, but this should be OK to merge as-is. It's at kingdonb/minio:canary, I put it in my deployment and terminated the old pod... logged into the database, created the bucket again, ran do_backup

Then verified with envdir "$WALE_ENVDIR" wal-e --terse backup-list that the backup made it.

LGTM2

@Cryptophobia
Copy link
Copy Markdown
Member

Alright sounds good! We will test again before next patch release.

Copy link
Copy Markdown
Member

@Cryptophobia Cryptophobia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Cryptophobia Cryptophobia merged commit 7d1876d into teamhephy:master Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants