Skip to content

feat(slugbuilder):update stack to heroku-18-build#10

Merged
Cryptophobia merged 1 commit into
teamhephy:masterfrom
duanhongyi:master
Oct 30, 2018
Merged

feat(slugbuilder):update stack to heroku-18-build#10
Cryptophobia merged 1 commit into
teamhephy:masterfrom
duanhongyi:master

Conversation

@duanhongyi
Copy link
Copy Markdown
Member

@duanhongyi duanhongyi commented Oct 27, 2018

Upgrade heroku-images to heroku-18-builder and update the latest release buildpacks

@duanhongyi duanhongyi force-pushed the master branch 4 times, most recently from ab15cc5 to 3ba7bb3 Compare October 27, 2018 17:54
Copy link
Copy Markdown
Member

@Cryptophobia Cryptophobia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread rootfs/builder/build.sh
@Cryptophobia
Copy link
Copy Markdown
Member

Cryptophobia commented Oct 28, 2018

Great work here @duanhongyi ! Did you test all of the example applications manually by deploying a custom image on minikube install or a test cluster?

Copy link
Copy Markdown
Member

@Cryptophobia Cryptophobia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one thing before we merge, can you change the commit message text to follow the commit-style 😁 : https://docs.teamhephy.com/contributing/submitting-a-pull-request/#commit-style

@duanhongyi
Copy link
Copy Markdown
Member Author

duanhongyi commented Oct 28, 2018

Great work here @duanhongyi ! Did you test all of the example applications manually by deploying a custom image on minikube install or a test cluster?

Yes, it runs on minikube; I spent more than an hour using Python to write a set of test cases; Because I don't know much about golang, but I'm learning recently.

@Cryptophobia
Copy link
Copy Markdown
Member

Cryptophobia commented Oct 29, 2018

@duanhongyi :

The commit messages for both PRs is:
upgrade STACK to heroku-18
it should be something like this:
feat(slugbuilder):update stack to heroku-18-build (for slugbuilder)
and
feat(slugrunner):update stack to heroku-18
you can do it easily on each repo if you do this:
git reset --soft HEAD~1
then git add . && git commit

Sorry to ask about this but our release tool www.github.com/teamhephy/deisrel captures these commit messages and creates great changelogs that we use for new releases.

@Cryptophobia Cryptophobia merged commit 2f0976d into teamhephy:master Oct 30, 2018
@Cryptophobia
Copy link
Copy Markdown
Member

Thanks for changing the commit message to conform to our commit-style. Merged and it will be in the upcoming Hephy Workflow v2.20.0! 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants