feat(slugbuilder):update stack to heroku-18-build#10
Conversation
ab15cc5 to
3ba7bb3
Compare
|
Great work here @duanhongyi ! Did you test all of the example applications manually by deploying a custom image on minikube install or a test cluster? |
Cryptophobia
left a comment
There was a problem hiding this comment.
Just one thing before we merge, can you change the commit message text to follow the commit-style 😁 : https://docs.teamhephy.com/contributing/submitting-a-pull-request/#commit-style
Yes, it runs on minikube; I spent more than an hour using Python to write a set of test cases; Because I don't know much about golang, but I'm learning recently. |
|
The commit messages for both PRs is: Sorry to ask about this but our release tool www.github.com/teamhephy/deisrel captures these commit messages and creates great changelogs that we use for new releases. |
|
Thanks for changing the commit message to conform to our commit-style. Merged and it will be in the upcoming |
Upgrade heroku-images to heroku-18-builder and update the latest release buildpacks