Add support for activity reset #2546
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
reviewed
Jun 5, 2025
There was a problem hiding this comment.
With some other SDKs, we have also provided a way to activities to see all states that may affect cancellation even though only one is thrown. We call it "cancellation details". I wonder if we should provide something like that in Java on the activity context (so they can see bools for cancel requested, paused, reset, etc).
There was a problem hiding this comment.
Yes, we should there is a separate issue for this
cretz
approved these changes
Jun 9, 2025
THardy98
reviewed
Jun 18, 2025
Comment on lines
+191
to
+194
| } else if (status.getActivityPaused()) { | ||
| throw new ActivityPausedException(); | ||
| } else if (status.getActivityReset()) { | ||
| throw new ActivityResetException(); |
There was a problem hiding this comment.
I think the ordering here matters.
What happens if a client issues a pause and a reset before the next heartbeat?
In principle, I think we would want to give precedence to reset. Reset > pause would be consistent with the priority/ordering in core as well
Comment on lines
+208
to
+211
| } else if (status.getActivityPaused()) { | ||
| throw new ActivityPausedException(); | ||
| } else if (status.getActivityReset()) { | ||
| throw new ActivityResetException(); |
Comment on lines
+231
to
+232
| } else if (status.getActivityReset()) { | ||
| lastException = new ActivityResetException(info); |
Comment on lines
+33
to
+34
| // assumeTrue( | ||
| // "Test Server doesn't support activity pause", SDKTestWorkflowRule.useExternalService); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for activity reset
closes #2488