Skip to content

Custom Op Linux ABI Incompatibility: Undefined Symbol #987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
seanpmorgan opened this issue Jan 31, 2020 · 3 comments · Fixed by #2682
Closed

Custom Op Linux ABI Incompatibility: Undefined Symbol #987

seanpmorgan opened this issue Jan 31, 2020 · 3 comments · Fixed by #2682
Labels
blocked Pending something elses completion bug Something isn't working custom-ops

Comments

@seanpmorgan
Copy link
Member

seanpmorgan commented Jan 31, 2020 •
edited
Loading

Creating this issue to consolidate the information. As seen in #676 #574

Overview:

The TF C++ API for kernel implementations are not ABI stable. Because of this we compile our pip package to be manylinux2010 compatible with GCC 7.3.1. This means that TF-Addons custom ops will work on pip installed TF, but are not guaranteed to work with TF built from source or installed from conda

This should not affect our macOS and Windows versions.

Temporary "fixes"

We implemented a lazy loading of custom-ops so majority of TFA functionality is not affected by this issue:
#869

Long term solution

RFC 133 is in the works to make a stable C ABI.
@seanpmorgan seanpmorgan added bug Something isn't working blocked Pending something elses completion custom-ops labels Jan 31, 2020
This was referenced Jan 31, 2020
Closed
Closed
Merged
@gabrieldemarmiesse gabrieldemarmiesse mentioned this issue Feb 20, 2020
Closed
@seanpmorgan seanpmorgan mentioned this issue Feb 22, 2020
Closed
@seanpmorgan seanpmorgan mentioned this issue Mar 5, 2020
Merged
@whatdhack
Copy link

whatdhack commented Apr 6, 2020 •
edited
Loading

I am seeing the undefined symbol problem with a custom built TF 1.14 python whl. What bazel build option should I use beside --cxxopt="-D_GLIBCXX_USE_CXX11_ABI=0" ? How do I specify compatibility with manylinux2010 and GCC 7.3.1

@seanpmorgan
Copy link
Member Author

I am seeing the undefined symbol problem with a custom built TF 1.14 python whl. What bazel build option should I use beside --cxxopt="-D_GLIBCXX_USE_CXX11_ABI=0" ? How do I specify compatibility with manylinux2010 and GCC 7.3.1

TensorFlow Addons only supports TF2.x. We have an issue for build from source compatibility but it would still only support TF2+ #770

@whatdhack
Copy link

Addons are similar to CustomOps in 1.x , right ? So has the same issue.

rosbo added a commit to Kaggle/docker-python that referenced this issue May 19, 2020
@rosbo
Build TensorFlow addons wheels.
75ddf53 
TFA must be build from source to support CustomOps. This is necessary
since TensorFlow C++ API is not ABI compatible. See:

- tensorflow/addons#987.
@rosbo rosbo mentioned this issue May 19, 2020
Merged
rosbo added a commit to Kaggle/docker-python that referenced this issue May 19, 2020
@rosbo
Add TensorFlow addons (TFA)
7c57501 
Note: TFA functionnality relying on Custom Op won't work. See:
tensorflow/addons#987.

BUG=145555176
@rosbo rosbo mentioned this issue May 20, 2020
Merged
@fsx950223 fsx950223 mentioned this issue Mar 10, 2022
Merged
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked Pending something elses completion bug Something isn't working custom-ops
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

migrate api and fix build issue fsx950223/addons
2 participants
@whatdhack @seanpmorgan