Skip to content

[localstack] Fix reuse mode #8844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 4, 2024
Merged

[localstack] Fix reuse mode #8844

merged 2 commits into from
Jul 4, 2024

Conversation

eddumelendez
Copy link
Member

2195610 allows to copy all org.testcontainers.* labels to LAMBDA_DOCKER_FLAGS and it generates a session-id breaking reuse mode. This commit waits until the container is starting with the right labels and then read the labels to set LAMBDA_DOCKER_FLAGS.

Fixes #8814

@eddumelendez eddumelendez requested a review from a team as a code owner July 3, 2024 22:58
@eddumelendez eddumelendez added this to the next milestone Jul 3, 2024
2195610 allows to copy all `org.testcontainers.*` labels to
`LAMBDA_DOCKER_FLAGS` and it generates a `session-id` breaking
reuse mode. This commit waits until the container is starting
with the right labels and then read the labels to set `LAMBDA_DOCKER_FLAGS`.

Fixes #8814
@eddumelendez eddumelendez merged commit 7989b20 into main Jul 4, 2024
99 checks passed
@eddumelendez eddumelendez deleted the gh-8814 branch July 4, 2024 00:53
lizhou1111 pushed a commit to lizhou1111/testcontainers-java that referenced this pull request Jul 13, 2024
2195610 allows to copy all `org.testcontainers.*` labels to
`LAMBDA_DOCKER_FLAGS` and it generates a `session-id` breaking
reuse mode. This commit waits until the container is starting
with the right labels and then read the labels to set `LAMBDA_DOCKER_FLAGS`.

Fixes testcontainers#8814
fokion pushed a commit to fokion/testcontainers-java that referenced this pull request Jan 18, 2025
2195610 allows to copy all `org.testcontainers.*` labels to
`LAMBDA_DOCKER_FLAGS` and it generates a `session-id` breaking
reuse mode. This commit waits until the container is starting
with the right labels and then read the labels to set `LAMBDA_DOCKER_FLAGS`.

Fixes testcontainers#8814
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: withReuse(true) does not reuse previously spun container
1 participant