Skip to content

Fix lambda container is dropped by ryuk (#848) #922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2025

Conversation

julienboulay
Copy link
Contributor

Fixes #848

Configure the LocalStack container to add sessionId when starting lambda container.
This allows the lambda container to be identified by the reaper and cleaned up on exit.

See Localstack documentation for more details about LAMBDA_DOCKER_FLAGS

Copy link

netlify bot commented Mar 11, 2025

Deploy Preview for testcontainers-node ready!

Name Link
🔨 Latest commit 5445630
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-node/deploys/67d096a200ccf90008addcfc
😎 Deploy Preview https://deploy-preview-922--testcontainers-node.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cristianrgreco cristianrgreco added bug Something isn't working patch Backward compatible bug fix labels Mar 11, 2025
@cristianrgreco cristianrgreco merged commit b31edb8 into testcontainers:main Mar 11, 2025
18 checks passed
@julienboulay
Copy link
Contributor Author

@cristianrgreco many thanks for your approval and reactivity.

Is it possible to create a new 10.18.1 release with this fix, please ?

@cristianrgreco
Copy link
Collaborator

cristianrgreco commented Mar 11, 2025

@julienboulay np, thank you for the PR!

I've merged another PR which was a minor change which hasn't yet been released. Because of that the next version will be 10.19.0. I'll trigger a release once I've merged #921 (includes some dependency updates to address some vulnerabilities)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working patch Backward compatible bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lambda container not being removed automatically
2 participants