Skip to content

Upgrade core dependencies #855

@Belco90

Description

@Belco90
Member

I'm creating this issue to keep discussing the upgrade of some core dependencies of this plugin, originated in #852 (@lesha1201).

typescript-eslint

We could support both v5 and v6, actually. I think it will make things more complicated, so let me think about it. There are other things more critical to be updated now.

Prettier

I already tried to upgrade to v3, but had to revert it because of breaking changes introduced. You can find more details in the revert PR.

TypeScript

Definitely interested in upgrading this one, and it's actually needed to upgrade prettier to v3 as described in the previous revert PR.

Jest

Not sure why this was updated in #852, but we need to upgrade it anyway. Shouldn't be blocked by anything This is blocked by Node.js v12 which is not supported by Jest v29.

So our priorities should be:

Other improvements

When Node.js compatibility for non-supported versions is dropped, we can apply more improvements:

Activity

Belco90

Belco90 commented on Dec 12, 2023

@Belco90
MemberAuthor

Just thinking out loud: another migration update plan for this plugin could be releasing a new major that upgrades typescript-eslint to v6 + drops Node.js support for the same versions as the future ESLint v9. Then when ESLint v9 gets released we don't release another major but a minor supporting both ESLint v8 and v9.

lesha1201

lesha1201 commented on Dec 12, 2023

@lesha1201
Contributor

@Belco90 Do you want to upgrade TS or I can open PR? I saw your notes about updating tsconfig in this PR #826 but not sure what exactly you want to update. I can open PR with these changes - 20c87e8 and you can either ask me to add some changes to tsconfig or push them directly.

Belco90

Belco90 commented on Dec 13, 2023

@Belco90
MemberAuthor

@Belco90 Do you want to upgrade TS or I can open PR? I saw your notes about updating tsconfig in this PR #826 but not sure what exactly you want to update. I can open PR with these changes - 20c87e8 and you can either ask me to add some changes to tsconfig or push them directly.

Feel free to create a PR! I can ask for some changes to tsconfig if needed.

pinned this issue on Jan 14, 2024
self-assigned this
on Jan 14, 2024
Belco90

Belco90 commented on Feb 25, 2024

@Belco90
MemberAuthor

I've updated the description, so we release a v7 dropping support for older Node.js versions similar to typescript-eslint v7.

Belco90

Belco90 commented on Apr 16, 2024

@Belco90
MemberAuthor

ESLint v9 has been released, so all the planned changes here can be done under the new major of the plugin.

G-Rath

G-Rath commented on Sep 27, 2024

@G-Rath
Contributor

fwiw I've opened #932 upgrading Prettier to v3

G-Rath

G-Rath commented on Oct 21, 2024

@G-Rath
Contributor

fwiw, over in eslint-plugin-jest we've have multiple major versions of @typescript-eslint/utils as a direct dependency for a while now without issue - there's a few edge cases with package managers sometimes aiming for the latest major and erroring if it's not compatible with the rest of the tree which is not ideal but at least devs can have everything happy if they're using slightly older majors with only a bit of manual nudging

added theissue type on May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Development

    No branches or pull requests

      Participants

      @Belco90@G-Rath@lesha1201

      Issue actions

        Upgrade core dependencies · Issue #855 · testing-library/eslint-plugin-testing-library