-
Notifications
You must be signed in to change notification settings - Fork 151
Description
I'm creating this issue to keep discussing the upgrade of some core dependencies of this plugin, originated in #852 (@lesha1201).
typescript-eslint
We could support both v5 and v6, actually. I think it will make things more complicated, so let me think about it. There are other things more critical to be updated now.
Prettier
I already tried to upgrade to v3, but had to revert it because of breaking changes introduced. You can find more details in the revert PR.
TypeScript
Definitely interested in upgrading this one, and it's actually needed to upgrade prettier to v3 as described in the previous revert PR.
Jest
Not sure why this was updated in #852, but we need to upgrade it anyway. Shouldn't be blocked by anything This is blocked by Node.js v12 which is not supported by Jest v29.
So our priorities should be:
- Upgrade TS to v5 --> chore: upgrade TypeScript to v5.0 #858Upgrade Prettier to v3 --> chore(deps-dev): upgrade Prettier to v3 #932Upgrade typescript-eslint to v7 (breaking change)Update Node.js engine requirement to
^18.18.0 || >=20.0.0
(breaking change) --> chore: drop support for old Node.js versions #898To pick up a draggable item, press the space bar. While dragging, use the arrow keys to move the item. Press space again to drop the item in its new position, or press escape to cancel.
Other improvements
When Node.js compatibility for non-supported versions is dropped, we can apply more improvements:
Upgrade Jest to v29Migrate test runner to vitestUpgrade TypeScript to the last v5.X (enabling pending things from chore: upgrade TypeScript to v5.0 #858)Replace npm with pnpm as the package manager --> chore: use pnpm as package manager #966Use tsup for bundling in both CJS and ESM formats --> Bundle plugin in ESM format #900To pick up a draggable item, press the space bar. While dragging, use the arrow keys to move the item. Press space again to drop the item in its new position, or press escape to cancel.
Activity
Belco90 commentedon Dec 12, 2023
Just thinking out loud: another migration update plan for this plugin could be releasing a new major that upgrades typescript-eslint to v6 + drops Node.js support for the same versions as the future ESLint v9. Then when ESLint v9 gets released we don't release another major but a minor supporting both ESLint v8 and v9.
lesha1201 commentedon Dec 12, 2023
@Belco90 Do you want to upgrade TS or I can open PR? I saw your notes about updating
tsconfig
in this PR #826 but not sure what exactly you want to update. I can open PR with these changes - 20c87e8 and you can either ask me to add some changes totsconfig
or push them directly.Belco90 commentedon Dec 13, 2023
Feel free to create a PR! I can ask for some changes to
tsconfig
if needed.Belco90 commentedon Feb 25, 2024
I've updated the description, so we release a v7 dropping support for older Node.js versions similar to typescript-eslint v7.
Belco90 commentedon Apr 16, 2024
ESLint v9 has been released, so all the planned changes here can be done under the new major of the plugin.
G-Rath commentedon Sep 27, 2024
fwiw I've opened #932 upgrading Prettier to v3
G-Rath commentedon Oct 21, 2024
fwiw, over in
eslint-plugin-jest
we've have multiple major versions of@typescript-eslint/utils
as a direct dependency for a while now without issue - there's a few edge cases with package managers sometimes aiming for the latest major and erroring if it's not compatible with the rest of the tree which is not ideal but at least devs can have everything happy if they're using slightly older majors with only a bit of manual nudging