TS - Adding toBeVisible declaration #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi there @gnapse or @kentcdodds, just checking in about the PR to add the TS type for toBeVisible in jest-dom. Let me know if there is anything you would like changed. Thank you for your time! |
kentcdodds
approved these changes
Jul 3, 2018
|
Thank you for your patience. Sorry that it took so long to merge! |
|
🎉 This PR is included in version 1.3.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
Seriously, no worries, thank you for responding and your time! Glad to be able to help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Adding toBeVisible to typescript definitions
Why:
To help typescript to know about the toBeVisible matcher
How:
I added the toBeVisible declaration as part of the interface
Checklist: